api-digester: Support old name for @backDeployed

Swift 5.7’s API digester supported the unofficial @_backDeploy attribute, writing it to digests under the name “BackDeploy”, but by the time it the proposal was accepted, the spelling in source code was @backDeployed and the spelling in digests became “BackDeployed”. Add a special case to the new digester to accept the old spelling. This should fix an issue seen in Swift CI where the WholeSDK API digester test couldn’t process the StoreKit framework.

Author: beccadax

lib/APIDigester/ModuleAnalyzerNodes.cpp

@@ -739,6 +739,10 @@ SDKNode* SDKNode::constructSDKNode(SDKContext &Ctx,
             auto Result = llvm::StringSwitch<DeclAttrKind>(GetScalarString(&N))
   #define DECL_ATTR(_, NAME, ...) .Case(#NAME, DeclAttrKind::DAK_##NAME)
   #include "swift/AST/Attr.def"
+            // BackDeployAttr was renamed to BackDeployedAttr, but not before a
+            // compiler shipped which used the old name in digests. Make the old
+            // name equivalent to the new one.
+            .Case("BackDeploy", DeclAttrKind::DAK_BackDeployed)
             .Default(DeclAttrKind::DAK_Count);
             if (Result == DAK_Count)
               Ctx.diagnose(&N, diag::sdk_node_unrecognized_decl_attr_kind,

test/api-digester/Inputs/cake_baseline/cake.swift

@@ -214,6 +214,11 @@ public class Zoo {
   public func getCurrentAnimalInlinable() -> [some Animal] {
     return [Cat()]
   }
+  @backDeployed(before: iOS 14.0, OSX 10.16, tvOS 14.0, watchOS 7.0)
+  @available(iOS 13.0, OSX 10.15, tvOS 13.0, watchOS 6.0, *)
+  public final func getCurrentAnimalBackDeployed() -> [Cat] {
+    return [Cat()]
+  }
 }
 
 public func returnFunctionTypeOwnershipChange() -> (C1) -> () { return { _ in } }

test/api-digester/Inputs/cake_current/cake.swift

@@ -227,6 +227,10 @@ public class Zoo {
   public func getCurrentAnimalInlinable() -> [some Animal] {
     return [Dog()]
   }
+  @available(iOS 13.0, OSX 10.15, tvOS 13.0, watchOS 6.0, *)
+  public final func getCurrentAnimalBackDeployed() -> [Cat] {
+    return [Cat()]
+  }
 }
 
 public func returnFunctionTypeOwnershipChange() -> (__owned C1) -> () { return { _ in } }

test/api-digester/Inputs/diagnostics-compare.json

@@ -5,7 +5,7 @@
   "children": [
     {
       "kind": "Function",
-      "declAttributes": ["Available", "ObjC"],
+      "declAttributes": ["Available", "ObjC", "BackDeployed"],
       "declKind": "Func",
       "name": "foo",
       "children": [],

test/api-digester/Inputs/diagnostics.json

@@ -6,13 +6,13 @@
   "children": [
     {
       "kind": "Zyzyx",
-      "typeAttributes": ["autoclosure", "fnord", "inout", "Available"],
+      "typeAttributes": ["autoclosure", "fnord", "inout", "Available", "BackDeploy"],
       "declAttributes": ["Available", "Fnord", "ObjC", "inout"],
       "declKind": "Subroutine"
     },
     {
       "kind": "Function",
-      "declAttributes": ["Available", "Fnord", "ObjC", "inout"],
+      "declAttributes": ["Available", "Fnord", "ObjC", "inout", "BackDeploy"],
       "declKind": "Func",
       "name": "foo",
       "children": [],

test/api-digester/Outputs/Cake.txt

@@ -43,6 +43,7 @@ cake: Func C1.foo1() is now not static
 cake: Func HasMutatingMethodClone.foo() has self access kind changing from Mutating to NonMutating
 cake: Func S1.foo1() has self access kind changing from NonMutating to Mutating
 cake: Func S1.foo3() is now static
+cake: Func Zoo.getCurrentAnimalBackDeployed() is now without @backDeployed
 cake: Var C1.CIIns1 changes from weak to strong
 cake: Var C1.CIIns2 changes from strong to weak
 cake: EnumElement FrozenKind.AddedCase has been added as a new enum case

test/api-digester/diagnostics.swift

@@ -20,5 +20,10 @@
 // Make sure we don't try to output a result:
 // NEGATIVE-NOT: "kind": "Root",
 
+// Older versions of the compiler used 'BackDeploy' for @_backDeploy. We now use
+// 'BackDeployed', but we should still support the old name.
+// NEGATIVE-NOT: error: unrecognized declaration attribute 'BackDeploy' in SDK node
+// NEGATIVE-NOT: is now without @backDeployed
+
 // Should not have any errors in the diagnostics-compare file.
 // NEGATIVE-NOT: diagnostics-compare.json:{{.*}}: error: