Instead of just fixing the ClosureLifetimeFixup change releasePartialApplyCapturedArg to handle undef captures

Author: aschwaighofer

lib/SILOptimizer/Mandatory/ClosureLifetimeFixup.cpp

@@ -458,9 +458,6 @@ static bool tryRewriteToPartialApplyStack(
     saveDeleteInst(convertOrPartialApply);
   saveDeleteInst(origPA);
 
-  // Only insert destroys for defined partial_apply arguments.
-  auto isDefined = [](SILValue arg) -> bool { return !isa<SILUndef>(arg); };
-
   // Insert destroys of arguments after the apply and the dealloc_stack.
   if (auto *apply = dyn_cast<ApplyInst>(singleApplyUser)) {
     auto insertPt = std::next(SILBasicBlock::iterator(apply));
@@ -469,12 +466,12 @@ static bool tryRewriteToPartialApplyStack(
       return true;
     SILBuilderWithScope b3(insertPt);
     b3.createDeallocStack(loc, newPA);
-    insertDestroyOfCapturedArguments(newPA, b3, isDefined);
+    insertDestroyOfCapturedArguments(newPA, b3);
   } else if (auto *tai = dyn_cast<TryApplyInst>(singleApplyUser)) {
     for (auto *succBB : tai->getSuccessorBlocks()) {
       SILBuilderWithScope b3(succBB->begin());
       b3.createDeallocStack(loc, newPA);
-      insertDestroyOfCapturedArguments(newPA, b3, isDefined);
+      insertDestroyOfCapturedArguments(newPA, b3);
     }
   } else {
     llvm_unreachable("Unknown FullApplySite instruction kind");

lib/SILOptimizer/Utils/InstOptUtils.cpp

@@ -1020,7 +1020,7 @@ void swift::releasePartialApplyCapturedArg(SILBuilder &builder, SILLocation loc,
   // possible for that value.
 
   // If we have qualified ownership, we should just emit a destroy value.
-  if (arg->getFunction()->hasOwnership()) {
+  if (builder.getFunction().hasOwnership()) {
     callbacks.createdNewInst(builder.createDestroyValue(loc, arg));
     return;
   }