Skip to content

Commit aabaca3

Browse files
committed
[llvm-objdump] Use "--" for long options in --help text
Single dash for these options is not recognised. Changes found by running this on the --help output and the user guide: grep -e ' -[a-zA-Z]\{2,\}' The user guide was updated in https://reviews.llvm.org/D92305 so no change there. Reviewed By: jhenderson, MaskRay Differential Revision: https://reviews.llvm.org/D92310
1 parent 22ccdb7 commit aabaca3

File tree

2 files changed

+20
-20
lines changed

2 files changed

+20
-20
lines changed

llvm/tools/llvm-objdump/MachODump.cpp

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -107,70 +107,70 @@ static cl::opt<bool> NoLeadingHeaders("no-leading-headers",
107107

108108
cl::opt<bool> objdump::UniversalHeaders(
109109
"universal-headers",
110-
cl::desc("Print Mach-O universal headers (requires -macho)"),
110+
cl::desc("Print Mach-O universal headers (requires --macho)"),
111111
cl::cat(MachOCat));
112112

113113
static cl::opt<bool> ArchiveMemberOffsets(
114114
"archive-member-offsets",
115115
cl::desc("Print the offset to each archive member for Mach-O archives "
116-
"(requires -macho and -archive-headers)"),
116+
"(requires --macho and --archive-headers)"),
117117
cl::cat(MachOCat));
118118

119119
cl::opt<bool> objdump::IndirectSymbols(
120120
"indirect-symbols",
121121
cl::desc(
122-
"Print indirect symbol table for Mach-O objects (requires -macho)"),
122+
"Print indirect symbol table for Mach-O objects (requires --macho)"),
123123
cl::cat(MachOCat));
124124

125125
cl::opt<bool> objdump::DataInCode(
126126
"data-in-code",
127127
cl::desc(
128-
"Print the data in code table for Mach-O objects (requires -macho)"),
128+
"Print the data in code table for Mach-O objects (requires --macho)"),
129129
cl::cat(MachOCat));
130130

131131
cl::opt<bool>
132132
objdump::LinkOptHints("link-opt-hints",
133133
cl::desc("Print the linker optimization hints for "
134-
"Mach-O objects (requires -macho)"),
134+
"Mach-O objects (requires --macho)"),
135135
cl::cat(MachOCat));
136136

137137
cl::opt<bool>
138138
objdump::InfoPlist("info-plist",
139139
cl::desc("Print the info plist section as strings for "
140-
"Mach-O objects (requires -macho)"),
140+
"Mach-O objects (requires --macho)"),
141141
cl::cat(MachOCat));
142142

143143
cl::opt<bool>
144144
objdump::DylibsUsed("dylibs-used",
145145
cl::desc("Print the shared libraries used for linked "
146-
"Mach-O files (requires -macho)"),
146+
"Mach-O files (requires --macho)"),
147147
cl::cat(MachOCat));
148148

149149
cl::opt<bool> objdump::DylibId("dylib-id",
150150
cl::desc("Print the shared library's id for the "
151-
"dylib Mach-O file (requires -macho)"),
151+
"dylib Mach-O file (requires --macho)"),
152152
cl::cat(MachOCat));
153153

154154
static cl::opt<bool>
155155
NonVerbose("non-verbose",
156156
cl::desc("Print the info for Mach-O objects in non-verbose or "
157-
"numeric form (requires -macho)"),
157+
"numeric form (requires --macho)"),
158158
cl::cat(MachOCat));
159159

160160
cl::opt<bool>
161161
objdump::ObjcMetaData("objc-meta-data",
162162
cl::desc("Print the Objective-C runtime meta data "
163-
"for Mach-O files (requires -macho)"),
163+
"for Mach-O files (requires --macho)"),
164164
cl::cat(MachOCat));
165165

166166
static cl::opt<std::string> DisSymName(
167167
"dis-symname",
168-
cl::desc("disassemble just this symbol's instructions (requires -macho)"),
168+
cl::desc("disassemble just this symbol's instructions (requires --macho)"),
169169
cl::cat(MachOCat));
170170

171171
static cl::opt<bool> NoSymbolicOperands(
172172
"no-symbolic-operands",
173-
cl::desc("do not symbolic operands when disassembling (requires -macho)"),
173+
cl::desc("do not symbolic operands when disassembling (requires --macho)"),
174174
cl::cat(MachOCat));
175175

176176
static cl::list<std::string>

llvm/tools/llvm-objdump/llvm-objdump.cpp

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ static cl::alias AllHeadersShort("x", cl::desc("Alias for --all-headers"),
101101
static cl::opt<std::string>
102102
ArchName("arch-name",
103103
cl::desc("Target arch to disassemble for, "
104-
"see -version for available targets"),
104+
"see --version for available targets"),
105105
cl::cat(ObjdumpCat));
106106

107107
cl::opt<bool>
@@ -274,7 +274,7 @@ static cl::alias PrivateHeadersShort("p",
274274
cl::list<std::string>
275275
objdump::FilterSections("section",
276276
cl::desc("Operate on the specified sections only. "
277-
"With -macho dump segment,section"),
277+
"With --macho dump segment,section"),
278278
cl::cat(ObjdumpCat));
279279
static cl::alias FilterSectionsj("j", cl::desc("Alias for --section"),
280280
cl::NotHidden, cl::Grouping, cl::Prefix,
@@ -303,7 +303,7 @@ static cl::opt<bool> PrintSource(
303303
cl::desc(
304304
"Display source inlined with disassembly. Implies disassemble object"),
305305
cl::cat(ObjdumpCat));
306-
static cl::alias PrintSourceShort("S", cl::desc("Alias for -source"),
306+
static cl::alias PrintSourceShort("S", cl::desc("Alias for --source"),
307307
cl::NotHidden, cl::Grouping,
308308
cl::aliasopt(PrintSource));
309309

@@ -335,11 +335,11 @@ static cl::alias DynamicSymbolTableShort("T",
335335
cl::NotHidden, cl::Grouping,
336336
cl::aliasopt(DynamicSymbolTable));
337337

338-
cl::opt<std::string> objdump::TripleName(
339-
"triple",
340-
cl::desc(
341-
"Target triple to disassemble for, see -version for available targets"),
342-
cl::cat(ObjdumpCat));
338+
cl::opt<std::string>
339+
objdump::TripleName("triple",
340+
cl::desc("Target triple to disassemble for, see "
341+
"--version for available targets"),
342+
cl::cat(ObjdumpCat));
343343

344344
cl::opt<bool> objdump::UnwindInfo("unwind-info",
345345
cl::desc("Display unwind information"),

0 commit comments

Comments
 (0)