Skip to content

Commit ab02434

Browse files
committed
---
yaml --- r: 293470 b: refs/heads/tensorflow c: 013b9bc h: refs/heads/master
1 parent cfc7908 commit ab02434

File tree

7 files changed

+34
-32
lines changed

7 files changed

+34
-32
lines changed

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -816,7 +816,7 @@ refs/tags/swift-DEVELOPMENT-SNAPSHOT-2018-04-25-a: 22f738a831d43aff2b9c9773bcb65
816816
refs/tags/swift-DEVELOPMENT-SNAPSHOT-2018-05-08-a: 7d98cc16689baba5c8a3b90a9329bdcc1a12b4e9
817817
refs/heads/cherr42: a566ad54b073c2c56ac0a705d0a5bed9743135a5
818818
"refs/heads/codable_test_comment_fix": fc8f6824f7f347e1e8db55bff62db385c5728b5a
819-
refs/heads/tensorflow: db0b802aee7b651cfa761b909ad4cec4ca7aedcd
819+
refs/heads/tensorflow: 013b9bcf31ca8a5d43c41b45f2b2a6c3631a08fb
820820
refs/tags/swift-4.1-DEVELOPMENT-SNAPSHOT-2018-05-11-a: 8126fd7a652e2f70ad6d76505239e34fb2ef3e1a
821821
refs/tags/swift-4.1-DEVELOPMENT-SNAPSHOT-2018-05-12-a: b3fd3dd84df6717f2e2e9df58c6d7e99fed57086
822822
refs/tags/swift-4.1-DEVELOPMENT-SNAPSHOT-2018-05-13-a: 71135119579039dc321c5f65d870050fe36efda2

branches/tensorflow/stdlib/public/core/Builtin.swift

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -312,11 +312,6 @@ func _uncheckedUnsafeAssume(_ condition: Bool) {
312312
@usableFromInline
313313
@_silgen_name("_swift_objcClassUsesNativeSwiftReferenceCounting")
314314
internal func _usesNativeSwiftReferenceCounting(_ theClass: AnyClass) -> Bool
315-
316-
/// Returns the class of a non-tagged-pointer Objective-C object
317-
@_effects(readonly)
318-
@_silgen_name("_swift_classOfObjCHeapObject")
319-
internal func _swift_classOfObjCHeapObject(_ object: AnyObject) -> AnyClass
320315
#else
321316
@inlinable
322317
@inline(__always)

branches/tensorflow/stdlib/public/core/StringBridge.swift

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,11 @@ private var kCFStringEncodingUTF8 : _swift_shims_CFStringEncoding {
125125
@inline(__always) get { return 0x8000100 }
126126
}
127127

128+
@_effects(readonly)
129+
private func _unsafeAddressOfCocoaStringClass(_ str: _CocoaString) -> UInt {
130+
return _swift_stdlib_unsafeAddressOfClass(str)
131+
}
132+
128133
internal enum _KnownCocoaString {
129134
case storage
130135
case shared
@@ -143,7 +148,7 @@ internal enum _KnownCocoaString {
143148
}
144149
#endif
145150

146-
switch unsafeBitCast(_swift_classOfObjCHeapObject(str), to: UInt.self) {
151+
switch _unsafeAddressOfCocoaStringClass(str) {
147152
case unsafeBitCast(__StringStorage.self, to: UInt.self):
148153
self = .storage
149154
case unsafeBitCast(__SharedStringStorage.self, to: UInt.self):

branches/tensorflow/stdlib/public/runtime/SwiftObject.mm

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -177,11 +177,6 @@ static Class _swift_getObjCClassOfAllocated(const void *object) {
177177
class_getInstanceSize(cls), mask));
178178
}
179179

180-
SWIFT_CC(swift) SWIFT_RUNTIME_STDLIB_API
181-
Class _swift_classOfObjCHeapObject(OpaqueValue *value) {
182-
return _swift_getObjCClassOfAllocated(value);
183-
}
184-
185180
SWIFT_CC(swift) SWIFT_RUNTIME_STDLIB_API
186181
NSString *swift_stdlib_getDescription(OpaqueValue *value,
187182
const Metadata *type);

branches/tensorflow/test/Interpreter/bridged_casts_folding.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// RUN: %target-run-simple-swift(-Onone) | %FileCheck %s
1+
// RUN: %target-run-simple-swift | %FileCheck %s
22
// RUN: %target-run-simple-swift(-O) | %FileCheck -check-prefix=CHECK-OPT %s
33

44
// NOTE: We use FileCheck for the crashing test cases to make sure we crash for

branches/tensorflow/test/SILOptimizer/definite_init_failable_initializers_objc.swift

Lines changed: 25 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
// RUN: %target-swift-frontend -emit-sil -disable-objc-attr-requires-foundation-module %s | %FileCheck %s
22

33
// REQUIRES: objc_interop
4+
// REQUIRES: rdar49942212
45

56
import ObjectiveC
67

@@ -97,46 +98,52 @@ class Cat : FakeNSObject {
9798
// CHECK-NEXT: cond_br [[COND]], bb1, bb2
9899

99100
// CHECK: bb1:
100-
// CHECK-NEXT: br [[ERROR_BRANCH:bb[0-9]+]]
101-
102-
// CHECK: bb{{[0-9]+}}:
101+
// CHECK-NEXT: br bb8
102+
103+
// CHECK: bb3:
104+
// CHECK: br bb5
105+
106+
// CHECK: bb4:
107+
// CHECK: br bb5
108+
109+
// CHECK: bb5
103110
// CHECK: [[SELF_INIT:%.+]] = objc_method %2 : $Cat, #Cat.init!initializer.1.foreign : (Cat.Type) -> (Int, Bool) -> Cat?
104-
// CHECK: [[NEW_OPT_SELF:%.+]] = apply [[SELF_INIT]]({{%.+}}, {{%.+}}, {{%.+}}) : $@convention(objc_method) (Int, ObjCBool, @owned Cat) -> @owned Optional<Cat>
111+
// CHECK: [[NEW_OPT_SELF:%.+]] = apply [[SELF_INIT]]({{%.+}}, {{%.+}}, %2) : $@convention(objc_method) (Int, ObjCBool, @owned Cat) -> @owned Optional<Cat>
105112
// CHECK: [[COND:%.+]] = select_enum [[NEW_OPT_SELF]] : $Optional<Cat>
106-
// CHECK-NEXT: cond_br [[COND]], [[SUCCESS_BRANCH:bb[0-9]+]], [[RELEASE_THEN_ERROR_BRANCH:bb[0-9]+]]
113+
// CHECK-NEXT: cond_br [[COND]], bb7, bb6
107114

108-
// CHECK: [[RELEASE_THEN_ERROR_BRANCH]]:
115+
// CHECK: bb6:
109116
// CHECK-NEXT: release_value [[NEW_OPT_SELF]]
110-
// CHECK-NEXT: br [[ERROR_BRANCH]]
117+
// CHECK-NEXT: br bb8
111118

112-
// CHECK: [[SUCCESS_BRANCH]]:
119+
// CHECK: bb7:
113120
// CHECK-NEXT: [[NEW_SELF:%.+]] = unchecked_enum_data [[NEW_OPT_SELF]] : $Optional<Cat>, #Optional.some!enumelt.1
114121
// CHECK-NEXT: store [[NEW_SELF]] to [[SELF_BOX]] : $*Cat
115122
// TODO: Once we re-enable arbitrary take promotion, this retain and the associated destroy_addr will go away.
116123
// CHECK-NEXT: strong_retain [[NEW_SELF]]
117124
// CHECK-NEXT: [[RESULT:%.+]] = enum $Optional<Cat>, #Optional.some!enumelt.1, [[NEW_SELF]] : $Cat
118125
// CHECK-NEXT: destroy_addr [[SELF_BOX]]
119126
// CHECK-NEXT: dealloc_stack [[SELF_BOX]] : $*Cat
120-
// CHECK-NEXT: br [[RESULT_BRANCH:bb[0-9]+]]([[RESULT]] : $Optional<Cat>)
127+
// CHECK-NEXT: br bb12([[RESULT]] : $Optional<Cat>)
121128

122-
// CHECK: [[ERROR_BRANCH]]:
129+
// CHECK: bb8:
123130
// CHECK-NEXT: [[COND:%.+]] = load [[HAS_RUN_INIT_BOX]] : $*Builtin.Int1
124-
// CHECK-NEXT: cond_br [[COND]], [[ERROR_WITHOUT_DESTROY_BRANCH:bb[0-9]+]], [[ERROR_WITH_DESTROY_BRANCH:bb[0-9]+]]
131+
// CHECK-NEXT: cond_br [[COND]], bb9, bb10
125132

126-
// CHECK: [[ERROR_WITHOUT_DESTROY_BRANCH]]:
127-
// CHECK-NEXT: br [[ERROR_CLEANUP_BRANCH:bb[0-9]+]]
133+
// CHECK: bb9:
134+
// CHECK-NEXT: br bb11
128135

129-
// CHECK: [[ERROR_WITH_DESTROY_BRANCH]]:
136+
// CHECK: bb10:
130137
// CHECK-NEXT: [[MOST_DERIVED_TYPE:%.+]] = value_metatype $@thick Cat.Type, %2 : $Cat
131138
// CHECK-NEXT: dealloc_partial_ref %2 : $Cat, [[MOST_DERIVED_TYPE]] : $@thick Cat.Type
132-
// CHECK-NEXT: br [[ERROR_CLEANUP_BRANCH]]
139+
// CHECK-NEXT: br bb11
133140

134-
// CHECK: [[ERROR_CLEANUP_BRANCH]]:
141+
// CHECK: bb11:
135142
// CHECK-NEXT: dealloc_stack [[SELF_BOX]] : $*Cat
136143
// CHECK-NEXT: [[NIL_RESULT:%.+]] = enum $Optional<Cat>, #Optional.none!enumelt
137-
// CHECK-NEXT: br [[RESULT_BRANCH]]([[NIL_RESULT]] : $Optional<Cat>)
144+
// CHECK-NEXT: br bb12([[NIL_RESULT]] : $Optional<Cat>)
138145

139-
// CHECK: [[RESULT_BRANCH]]([[RESULT:%.+]] : $Optional<Cat>):
146+
// CHECK: bb12([[RESULT:%.+]] : $Optional<Cat>):
140147
// CHECK-NEXT: dealloc_stack [[HAS_RUN_INIT_BOX]] : $*Builtin.Int1
141148
// CHECK-NEXT: return [[RESULT]] : $Optional<Cat>
142149

branches/tensorflow/utils/build-script-impl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3103,7 +3103,7 @@ for host in "${ALL_HOSTS[@]}"; do
31033103
call mkdir -p "${results_dir}"
31043104

31053105
if [[ "$using_xcodebuild" == "TRUE" ]] ; then
3106-
LLDB_DOTEST_CC_OPTS="${LLDB_DOTEST_CC_OPTS} --filecheck $(build_directory $LOCAL_HOST llvm)/bin/FileCheck"
3106+
LLDB_DOTEST_CC_OPTS="${LLDB_DOTEST_CC_OPTS} --filecheck $(build_directory $LOCAL_HOST llvm)/bin/FileCheck --dsymutil $(build_directory $LOCAL_HOST llvm)/bin/dsymutil"
31073107
fi
31083108

31093109
# Prefer to use lldb-dotest, as building it guarantees that we build all

0 commit comments

Comments
 (0)