Skip to content

Commit ad14d02

Browse files
committed
cleanup
1 parent b19e073 commit ad14d02

File tree

2 files changed

+3
-11
lines changed

2 files changed

+3
-11
lines changed

lib/SIL/Verifier/SILVerifier.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5536,11 +5536,6 @@ class SILVerifier : public SILVerifierBase<SILVerifier> {
55365536
if (term->isFunctionExiting()) {
55375537
require(state.Stack.empty(),
55385538
"return with stack allocs that haven't been deallocated");
5539-
if (!state.ActiveOps.empty()) {
5540-
for (auto op : state.ActiveOps) {
5541-
op->dump();
5542-
}
5543-
}
55445539
require(state.ActiveOps.empty(),
55455540
"return with operations still active");
55465541
require(!state.GotAsyncContinuation,

lib/SILGen/SILGenDistributed.cpp

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1016,7 +1016,6 @@ void SILGenFunction::emitDistributedThunk(SILDeclRef thunk) {
10161016
SmallVector<Type, 1> subTypes;
10171017
SmallVector<ProtocolConformanceRef, 2> subConformances;
10181018

1019-
// subTypes.push_back(paramTy.getASTType());
10201019
subTypes.push_back(paramTy);
10211020

10221021
subs = SubstitutionMap::get(recordArgumentGenericSig, subTypes,
@@ -1535,16 +1534,14 @@ void SILGenFunction::emitDistributedThunk(SILDeclRef thunk) {
15351534
}
15361535
{
15371536
// FIXME(distributed): manual since I could not figure out how to NOT destroy_addr in the error path, where the memory is not initialized, so the destroy would fail SIL verification
1538-
// emitThrowWithCleanupBasicBlock(*this, loc, thunk, remoteCallErrorBB, errorBB,
1539-
// /*endAccesses*/{invocationEncoderAccess},
1540-
// /*endLifetimes*/{remoteCallSystemSelf});
1537+
// emitThrowWithCleanupBasicBlock(*this, loc, thunk, remoteCallErrorBB, errorBB,
1538+
// /*endAccesses*/{invocationEncoderAccess},
1539+
// /*endLifetimes*/{remoteCallSystemSelf});
15411540
B.emitBlock(remoteCallErrorBB);
15421541
SILValue error = remoteCallErrorBB->createPhiArgument(
15431542
fnConv.getSILErrorType(getTypeExpansionContext()),
15441543
OwnershipKind::Owned);
15451544

1546-
// auto result = remoteCallReturnValue.getValue();
1547-
15481545
// TODO(distributed): make those into cleanups
15491546
B.createEndAccess(loc, invocationEncoderAccess, /*aborted=*/false);
15501547

0 commit comments

Comments
 (0)