Skip to content

Commit ad8e109

Browse files
committed
[build] Disable cleaning sourcekit-lsp by default, rather than having the flag do nothing
Rather than make this change, swiftlang/sourcekit-lsp@37d003eb7 had the `--no-clean` flag do nothing, which means the flag can't be used at all.
1 parent b6e7a51 commit ad8e109

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

utils/swift_build_support/swift_build_support/products/indexstoredb.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ def get_dependencies(cls):
8585

8686

8787
def run_build_script_helper(action, host_target, product, args,
88-
sanitize_all=False, clean=True):
88+
sanitize_all=False, clean=False):
8989
script_path = os.path.join(
9090
product.source_dir, 'Utilities', 'build-script-helper.py')
9191

utils/swift_build_support/swift_build_support/products/sourcekitlsp.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,14 +54,14 @@ def should_test(self, host_target):
5454
def test(self, host_target):
5555
indexstoredb.run_build_script_helper(
5656
'test', host_target, self, self.args,
57-
self.args.test_sourcekitlsp_sanitize_all, clean=False)
57+
self.args.test_sourcekitlsp_sanitize_all)
5858

5959
def should_install(self, host_target):
6060
return self.args.install_sourcekitlsp
6161

6262
def install(self, host_target):
6363
indexstoredb.run_build_script_helper(
64-
'install', host_target, self, self.args, clean=False)
64+
'install', host_target, self, self.args)
6565

6666
@classmethod
6767
def get_dependencies(cls):

0 commit comments

Comments
 (0)