[Gardening] Sunk static function to use.

Now that the other caller of the function has been removed, it's more
convenient to have it adjacent to the only remaining caller.

Author: nate-chandler

lib/SIL/IR/SILInstruction.cpp

@@ -1825,49 +1825,8 @@ bool SILInstruction::maySuspend() const {
   if (auto applySite = FullApplySite::isa(const_cast<SILInstruction*>(this))) {
     return applySite.getOrigCalleeType()->isAsync();
   }
-  
-  return false;
-}
-
-static bool
-visitRecursivelyLifetimeEndingUses(
-  SILValue i, bool &noUsers,
-  llvm::function_ref<bool(Operand *)> visitScopeEnd,
-  llvm::function_ref<bool(Operand *)> visitUnknownUse) {
-
-  StackList<SILValue> values(i->getFunction());
-  values.push_back(i);
-
-  while (!values.empty()) {
-    auto value = values.pop_back_val();
-    for (Operand *use : value->getConsumingUses()) {
-      noUsers = false;
-      if (isa<DestroyValueInst>(use->getUser())) {
-        if (!visitScopeEnd(use)) {
-          return false;
-        }
-        continue;
-      }
-      if (auto *ret = dyn_cast<ReturnInst>(use->getUser())) {
-        auto fnTy = ret->getFunction()->getLoweredFunctionType();
-        assert(!fnTy->getLifetimeDependencies().empty());
-        if (!visitScopeEnd(use)) {
-          return false;
-        }
-        continue;
-      }
-      // FIXME: Handle store to indirect result
 
-      auto *user = use->getUser();
-      if (user->getNumResults() == 0) {
-        return visitUnknownUse(use);
-      }
-      for (auto res : use->getUser()->getResults()) {
-        values.push_back(res);
-      }
-    }
-  }
-  return true;
+  return false;
 }
 
 bool
@@ -1964,6 +1923,47 @@ FunctionTest PartialApplyPrintOnStackLifetimeEnds(
     });
 } // end namespace swift::test
 
+static bool
+visitRecursivelyLifetimeEndingUses(
+  SILValue i, bool &noUsers,
+  llvm::function_ref<bool(Operand *)> visitScopeEnd,
+  llvm::function_ref<bool(Operand *)> visitUnknownUse) {
+
+  StackList<SILValue> values(i->getFunction());
+  values.push_back(i);
+
+  while (!values.empty()) {
+    auto value = values.pop_back_val();
+    for (Operand *use : value->getConsumingUses()) {
+      noUsers = false;
+      if (isa<DestroyValueInst>(use->getUser())) {
+        if (!visitScopeEnd(use)) {
+          return false;
+        }
+        continue;
+      }
+      if (auto *ret = dyn_cast<ReturnInst>(use->getUser())) {
+        auto fnTy = ret->getFunction()->getLoweredFunctionType();
+        assert(!fnTy->getLifetimeDependencies().empty());
+        if (!visitScopeEnd(use)) {
+          return false;
+        }
+        continue;
+      }
+      // FIXME: Handle store to indirect result
+
+      auto *user = use->getUser();
+      if (user->getNumResults() == 0) {
+        return visitUnknownUse(use);
+      }
+      for (auto res : use->getUser()->getResults()) {
+        values.push_back(res);
+      }
+    }
+  }
+  return true;
+}
+
 // FIXME: Rather than recursing through all results, this should only recurse
 // through ForwardingInstruction and OwnershipTransitionInstruction and the
 // client should prove that any other uses cannot be upstream from a consume of