Merge pull request #73150 from gottesmm/release/6.0-region-iso

[6.0][region-isolation] Cherry-pick recent work

Author: gottesmm

docs/DebuggingTheCompiler.md

@@ -49,6 +49,7 @@ benefit of all Swift developers.
     - [Manually symbolication using LLDB](#manually-symbolication-using-lldb)
     - [Viewing allocation history, references, and page-level info](#viewing-allocation-history-references-and-page-level-info)
     - [Printing memory contents](#printing-memory-contents)
+    - [Windows Error Codes](#windows-error-codes)
 - [Debugging LLDB failures](#debugging-lldb-failures)
     - ["Types" Log](#types-log)
     - ["Expression" Log](#expression-log)
@@ -1058,6 +1059,36 @@ The following specifiers are available:
 * w - word (32-bit value)
 * g - giant word (64-bit value)
 
+## Windows Error Codes
+
+When debugging programs on Windows, sometimes one will run into an error message with a mysterious error code. E.x.:
+
+```
+note: command had no output on stdout or stderr
+error: command failed with exit status: 0xc0000135
+```
+
+These on windows are called HRESULT values. In the case above, the HRESULT is telling me that a DLL was not found. I discovered this
+by running the Microsoft provided [System Error Code Lookup Tool](https://learn.microsoft.com/en-us/windows/win32/debug/system-error-code-lookup-tool). After running
+this tool with the relevant error code on a windows machine, I got back the following result:
+
+```
+# for hex 0xc0000135 / decimal -1073741515
+  STATUS_DLL_NOT_FOUND                                           ntstatus.h   
+# The code execution cannot proceed because %hs was not
+# found. Reinstalling the program may fix this problem.
+# as an HRESULT: Severity: FAILURE (1), FACILITY_NULL (0x0), Code 0x135
+# for hex 0x135 / decimal 309
+  ERROR_NOTIFICATION_GUID_ALREADY_DEFINED                        winerror.h   
+# The specified file already has a notification GUID
+# associated with it.
+```
+
+Some relevant Microsoft documentation:
+
+* https://learn.microsoft.com/en-us/windows/win32/seccrypto/common-hresult-values
+* https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-erref/0642cb2f-2075-4469-918c-4441e69c548a
+* https://learn.microsoft.com/en-us/windows/win32/debug/system-error-codes--0-499-
 
 # Debugging LLDB failures
 

include/swift/AST/DiagnosticsSIL.def

@@ -971,7 +971,7 @@ NOTE(regionbasedisolation_isolated_since_in_same_region_basename, none,
 //
 
 ERROR(regionbasedisolation_named_transfer_yields_race, none,
-      "transferring %0 may cause a race",
+      "transferring %0 may cause a data race",
       (Identifier))
 
 NOTE(regionbasedisolation_named_info_transfer_yields_race, none,

include/swift/SIL/SILType.h

@@ -911,8 +911,16 @@ class SILType {
 
   bool isMarkedAsImmortal() const;
 
+  /// Returns true if this type is an actor type. Returns false if this is any
+  /// other type. This includes distributed actors. To check for distributed
+  /// actors and actors, use isAnyActor().
   bool isActor() const { return getASTType()->isActorType(); }
 
+  bool isDistributedActor() const { return getASTType()->isDistributedActor(); }
+
+  /// Returns true if this type is an actor or a distributed actor.
+  bool isAnyActor() const { return getASTType()->isAnyActorType(); }
+
   /// Returns true if this function conforms to the Sendable protocol.
   bool isSendable(SILFunction *fn) const;
 

include/swift/SILOptimizer/Analysis/RegionAnalysis.h

@@ -28,7 +28,7 @@ class RegionAnalysisFunctionInfo;
 namespace regionanalysisimpl {
 
 using TransferringOperandSetFactory = Partition::TransferringOperandSetFactory;
-using TrackableValueID = PartitionPrimitives::Element;
+using Element = PartitionPrimitives::Element;
 using Region = PartitionPrimitives::Region;
 
 /// Check if the passed in type is NonSendable.
@@ -88,9 +88,13 @@ class BlockPartitionState {
 
   TransferringOperandSetFactory &ptrSetFactory;
 
+  TransferringOperandToStateMap &transferringOpToStateMap;
+
   BlockPartitionState(SILBasicBlock *basicBlock,
                       PartitionOpTranslator &translator,
-                      TransferringOperandSetFactory &ptrSetFactory);
+                      TransferringOperandSetFactory &ptrSetFactory,
+                      IsolationHistory::Factory &isolationHistoryFactory,
+                      TransferringOperandToStateMap &transferringOpToStateMap);
 
 public:
   bool getLiveness() const { return isLive; }
@@ -171,7 +175,7 @@ class regionanalysisimpl::TrackableValueState {
 
   SILIsolationInfo getIsolationRegionInfo() const { return regionInfo; }
 
-  TrackableValueID getID() const { return TrackableValueID(id); }
+  Element getID() const { return Element(id); }
 
   void addFlag(TrackableValueFlag flag) { flagSet |= flag; }
 
@@ -182,7 +186,7 @@ class regionanalysisimpl::TrackableValueState {
        << "][is_no_alias: " << (isNoAlias() ? "yes" : "no")
        << "][is_sendable: " << (isSendable() ? "yes" : "no")
        << "][region_value_kind: ";
-    getIsolationRegionInfo().print(os);
+    getIsolationRegionInfo().printForDiagnostics(os);
     os << "].";
   }
 
@@ -272,9 +276,7 @@ class regionanalysisimpl::TrackableValue {
     return valueState.getIsolationRegionInfo();
   }
 
-  TrackableValueID getID() const {
-    return TrackableValueID(valueState.getID());
-  }
+  Element getID() const { return Element(valueState.getID()); }
 
   /// Return the representative value of this equivalence class of values.
   RepresentativeValue getRepresentative() const { return representativeValue; }
@@ -285,6 +287,11 @@ class regionanalysisimpl::TrackableValue {
   /// parameter.
   bool isTransferringParameter() const;
 
+  void printIsolationInfo(SmallString<64> &outString) const {
+    llvm::raw_svector_ostream os(outString);
+    getIsolationRegionInfo().printForDiagnostics(os);
+  }
+
   void print(llvm::raw_ostream &os) const {
     os << "TrackableValue. State: ";
     valueState.print(os);
@@ -311,7 +318,6 @@ class RegionAnalysisValueMap {
   using Region = PartitionPrimitives::Region;
   using TrackableValue = regionanalysisimpl::TrackableValue;
   using TrackableValueState = regionanalysisimpl::TrackableValueState;
-  using TrackableValueID = Element;
   using RepresentativeValue = regionanalysisimpl::RepresentativeValue;
 
 private:
@@ -365,14 +371,14 @@ class RegionAnalysisValueMap {
       SILInstruction *introducingInst) const;
 
 private:
-  std::optional<TrackableValue> getValueForId(TrackableValueID id) const;
+  std::optional<TrackableValue> getValueForId(Element id) const;
   std::optional<TrackableValue> tryToTrackValue(SILValue value) const;
   TrackableValue
   getActorIntroducingRepresentative(SILInstruction *introducingInst,
                                     SILIsolationInfo isolation) const;
   bool mergeIsolationRegionInfo(SILValue value, SILIsolationInfo isolation);
   bool valueHasID(SILValue value, bool dumpIfHasNoID = false);
-  TrackableValueID lookupValueID(SILValue value);
+  Element lookupValueID(SILValue value);
 };
 
 class RegionAnalysisFunctionInfo {
@@ -394,6 +400,10 @@ class RegionAnalysisFunctionInfo {
 
   TransferringOperandSetFactory ptrSetFactory;
 
+  IsolationHistory::Factory isolationHistoryFactory;
+
+  TransferringOperandToStateMap transferringOpToStateMap;
+
   // We make this optional to prevent an issue that we have seen on windows when
   // capturing a field in a closure that is used to initialize a different
   // field.
@@ -489,6 +499,16 @@ class RegionAnalysisFunctionInfo {
     return valueMap;
   }
 
+  IsolationHistory::Factory &getIsolationHistoryFactory() {
+    assert(supportedFunction && "Unsupported Function?!");
+    return isolationHistoryFactory;
+  }
+
+  TransferringOperandToStateMap &getTransferringOpToStateMap() {
+    assert(supportedFunction && "Unsupported Function?!");
+    return transferringOpToStateMap;
+  }
+
   bool isClosureCaptured(SILValue value, Operand *op);
 
   static SILValue getUnderlyingTrackedValue(SILValue value);