[IRGen] Insts with packs in ops/results may alloc.

Instead of assuming that the list of instructions known to allocate pack
metadata is exhaustive and returning false from mayRequirePackMetadata
for all others, consider the types of the results and operands of other
instructions and look for packs.

Author: nate-chandler

lib/SIL/IR/SILInstruction.cpp

@@ -1318,6 +1318,26 @@ bool SILInstruction::mayRequirePackMetadata() const {
     return ty->hasAnyPack();
   }
   default:
+    // DeallocationInst subclasses.  They can never result in metadata
+    // materialization.
+    if (isa<DeallocationInst>(this))
+      return false;
+
+    // Check results and operands for packs.  If a pack appears, lowering the
+    // instruction might result in pack metadata emission.
+    for (auto result : getResults()) {
+      if (result->getType().hasAnyPack())
+        return true;
+    }
+    for (auto operandTy : getOperandTypes()) {
+      if (operandTy.hasAnyPack())
+        return true;
+    }
+    for (auto &tdo : getTypeDependentOperands()) {
+      if (tdo.get()->getType().hasAnyPack())
+        return true;
+    }
+
     return false;
   }
 }