[region-isolation] Add support for yield, switch_enum_addr.

Author: gottesmm

lib/SILOptimizer/Mandatory/TransferNonSendable.cpp

@@ -2355,17 +2355,17 @@ CONSTANT_TRANSLATION(AbortApplyInst, Ignored)
 
 // Ignored terminators.
 CONSTANT_TRANSLATION(CondFailInst, Ignored)
-CONSTANT_TRANSLATION(SwitchEnumAddrInst, Ignored)
 // Switch value inst is ignored since we only switch over integers and
 // function_ref/class_method which are considered sendable.
 CONSTANT_TRANSLATION(SwitchValueInst, Ignored)
 CONSTANT_TRANSLATION(UnreachableInst, Ignored)
 CONSTANT_TRANSLATION(UnwindInst, Ignored)
-CONSTANT_TRANSLATION(YieldInst, Ignored)
 
 // Terminators that only need require.
 CONSTANT_TRANSLATION(ReturnInst, Require)
 CONSTANT_TRANSLATION(ThrowInst, Require)
+CONSTANT_TRANSLATION(SwitchEnumAddrInst, Require)
+CONSTANT_TRANSLATION(YieldInst, Require)
 
 // Unhandled instructions
 CONSTANT_TRANSLATION(AllocVectorInst, Unhandled)

test/Concurrency/sendnonsendable_basic.sil

@@ -7,9 +7,15 @@ import Swift
 class NonSendableKlass {}
 
 sil @transferKlass : $@convention(thin) @async (@guaranteed NonSendableKlass) -> ()
+sil @transferIndirect : $@convention(thin) @async <τ_0_0> (@in_guaranteed τ_0_0) -> ()
 sil @useKlass : $@convention(thin) (@guaranteed NonSendableKlass) -> ()
 sil @constructKlass : $@convention(thin) () -> @owned NonSendableKlass
 
+enum FakeOptional<T> {
+case none
+case some(T)
+}
+
 /////////////////
 // MARK: Tests //
 /////////////////
@@ -28,3 +34,57 @@ bb0:
   %9999 = tuple ()
   return %9999 : $()
 }
+
+sil [ossa] @yield_error_test : $@yield_once @convention(thin) @async () -> @yields @in_guaranteed NonSendableKlass {
+bb0:
+  %0 = function_ref @constructKlass : $@convention(thin) () -> @owned NonSendableKlass
+  %1 = apply %0() : $@convention(thin) () -> @owned NonSendableKlass
+  %2 = alloc_stack $NonSendableKlass
+  %3 = store_borrow %1 to %2 : $*NonSendableKlass
+  %4 = function_ref @transferIndirect : $@convention(thin) @async <τ_0_0> (@in_guaranteed τ_0_0) -> ()
+  apply [caller_isolation=nonisolated] [callee_isolation=global_actor] %4<NonSendableKlass>(%3) : $@convention(thin) @async <τ_0_0> (@in_guaranteed τ_0_0) -> ()
+  // expected-warning @-1 {{passing argument of non-sendable type 'NonSendableKlass' from nonisolated context to global actor '<null>'-isolated context at this call site could yield a race with accesses later in this function}}
+  yield %3 : $*NonSendableKlass, resume bb1, unwind bb2
+  // expected-note @-1 {{access here could race}}
+
+bb1:
+  end_borrow %3 : $*NonSendableKlass
+  dealloc_stack %2 : $*NonSendableKlass
+  destroy_value %1 : $NonSendableKlass
+  %9999 = tuple ()
+  return %9999 : $()
+
+bb2:
+  end_borrow %3 : $*NonSendableKlass
+  dealloc_stack %2 : $*NonSendableKlass
+  destroy_value %1 : $NonSendableKlass
+  unwind
+}
+
+sil [ossa] @switch_enum_addr_inst : $@yield_once @convention(thin) @async () -> () {
+bb0:
+  %0 = function_ref @constructKlass : $@convention(thin) () -> @owned NonSendableKlass
+  %1 = apply %0() : $@convention(thin) () -> @owned NonSendableKlass
+  %2 = alloc_stack $FakeOptional<NonSendableKlass>
+  %1a = enum $FakeOptional<NonSendableKlass>, #FakeOptional.some!enumelt, %1 : $NonSendableKlass
+  store %1a to [init] %2 : $*FakeOptional<NonSendableKlass>
+  %4 = function_ref @transferIndirect : $@convention(thin) @async <τ_0_0> (@in_guaranteed τ_0_0) -> ()
+  apply [caller_isolation=nonisolated] [callee_isolation=global_actor] %4<FakeOptional<NonSendableKlass>>(%2) : $@convention(thin) @async <τ_0_0> (@in_guaranteed τ_0_0) -> ()
+  // expected-warning @-1 {{passing argument of non-sendable type 'FakeOptional<NonSendableKlass>' from nonisolated context to global actor '<null>'-isolated context at this call site could yield a race with accesses later in this function}}
+  switch_enum_addr %2 : $*FakeOptional<NonSendableKlass>, case #FakeOptional.some!enumelt: bb1, case #FakeOptional.none!enumelt: bb2
+  // expected-note @-1 {{access here could race}}
+
+bb1:
+  destroy_addr %2 : $*FakeOptional<NonSendableKlass>
+  dealloc_stack %2 : $*FakeOptional<NonSendableKlass>
+  br bb3
+
+bb2:
+  destroy_addr %2 : $*FakeOptional<NonSendableKlass>
+  dealloc_stack %2 : $*FakeOptional<NonSendableKlass>
+  br bb3
+
+bb3:
+  %9999 = tuple ()
+  return %9999 : $()
+}