Skip to content

Commit b1b9b28

Browse files
author
Emanuel Zephir
committed
Revert "[StdLib] Extend ReflectionHashing test to pass on Linux"
This test expects consistent hash code generation on any given platform. However String instance generate different values on Linux depending on which version of libicu is installed, causing environment-specific test failures. This reverts commit def419b.
1 parent cbb95a2 commit b1b9b28

File tree

1 file changed

+4
-20
lines changed

1 file changed

+4
-20
lines changed

test/1_stdlib/ReflectionHashing.swift

Lines changed: 4 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
// RUN: %target-run %t.out
33
// REQUIRES: executable_test
44

5+
// XFAIL: linux
6+
57
//
68
// This file contains reflection tests that depend on hash values.
79
// Don't add other tests here.
@@ -36,7 +38,7 @@ Reflection.test("Dictionary") {
3638
var output = ""
3739
dump(dict, &output)
3840

39-
#if _runtime(_ObjC) && (arch(i386) || arch(arm))
41+
#if arch(i386) || arch(arm)
4042
var expected = ""
4143
expected += "▿ 5 key/value pairs\n"
4244
expected += " ▿ [0]: (2 elements)\n"
@@ -54,7 +56,7 @@ Reflection.test("Dictionary") {
5456
expected += " ▿ [4]: (2 elements)\n"
5557
expected += " - .0: Three\n"
5658
expected += " - .1: 3\n"
57-
#elseif _runtime(_ObjC) && (arch(x86_64) || arch(arm64))
59+
#elseif arch(x86_64) || arch(arm64)
5860
var expected = ""
5961
expected += "▿ 5 key/value pairs\n"
6062
expected += " ▿ [0]: (2 elements)\n"
@@ -72,24 +74,6 @@ Reflection.test("Dictionary") {
7274
expected += " ▿ [4]: (2 elements)\n"
7375
expected += " - .0: Four\n"
7476
expected += " - .1: 4\n"
75-
#elseif !_runtime(_ObjC) && arch(x86_64)
76-
var expected = ""
77-
expected += "▿ 5 key/value pairs\n"
78-
expected += " ▿ [0]: (2 elements)\n"
79-
expected += " - .0: One\n"
80-
expected += " - .1: 1\n"
81-
expected += " ▿ [1]: (2 elements)\n"
82-
expected += " - .0: Five\n"
83-
expected += " - .1: 5\n"
84-
expected += " ▿ [2]: (2 elements)\n"
85-
expected += " - .0: Two\n"
86-
expected += " - .1: 2\n"
87-
expected += " ▿ [3]: (2 elements)\n"
88-
expected += " - .0: Four\n"
89-
expected += " - .1: 4\n"
90-
expected += " ▿ [4]: (2 elements)\n"
91-
expected += " - .0: Three\n"
92-
expected += " - .1: 3\n"
9377
#else
9478
fatalError("unimplemented")
9579
#endif

0 commit comments

Comments
 (0)