Code review feedback

Author: Brian King

lib/Sema/MiscDiagnostics.cpp

@@ -2408,9 +2408,9 @@ void VarDeclUsageChecker::handleIfConfig(IfConfigStmt *ICS) {
 /// Apply the warnings managed by VarDeclUsageChecker to the top level
 /// code declarations that haven't been checked yet.
 void swift::
-performTopLevelDeclDiagnostics(TypeChecker &TC, TopLevelCodeDecl &TLCD) {
+performTopLevelDeclDiagnostics(TypeChecker &TC, TopLevelCodeDecl *TLCD) {
   VarDeclUsageChecker checker(TC.Diags);
-  TLCD.walk(checker);
+  TLCD->walk(checker);
 }
 
 /// Perform diagnostics for func/init/deinit declarations.

lib/Sema/MiscDiagnostics.h

@@ -44,7 +44,7 @@ void performAbstractFuncDeclDiagnostics(TypeChecker &TC,
                                         AbstractFunctionDecl *AFD);
 
 /// Perform diagnostics on the top level code declaration.
-void performTopLevelDeclDiagnostics(TypeChecker &TC, TopLevelCodeDecl &TLCD);
+void performTopLevelDeclDiagnostics(TypeChecker &TC, TopLevelCodeDecl *TLCD);
 
 /// Emit a fix-it to set the accessibility of \p VD to \p desiredAccess.
 ///

lib/Sema/TypeCheckStmt.cpp

@@ -1585,6 +1585,5 @@ void TypeChecker::typeCheckTopLevelCodeDecl(TopLevelCodeDecl *TLCD) {
   StmtChecker(*this, TLCD).typeCheckStmt(Body);
   TLCD->setBody(Body);
   checkTopLevelErrorHandling(TLCD);
-  if (TLCD) 
-    performTopLevelDeclDiagnostics(*this, *TLCD);
+  performTopLevelDeclDiagnostics(*this, TLCD);
 }