Skip to content

Commit b4e9af3

Browse files
committed
---
yaml --- r: 341958 b: refs/heads/rxwei-patch-1 c: 1e00633 h: refs/heads/master
1 parent 8b40d07 commit b4e9af3

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1015,7 +1015,7 @@ refs/tags/swift-DEVELOPMENT-SNAPSHOT-2018-08-18-a: b10b1fce14385faa6d44f6b933e95
10151015
refs/heads/rdar-43033749-fix-batch-mode-no-diags-swift-5.0-branch: a14e64eaad30de89f0f5f0b2a782eed7ecdcb255
10161016
refs/heads/revert-19006-error-bridging-integer-type: 8a9065a3696535305ea53fe9b71f91cbe6702019
10171017
refs/heads/revert-19050-revert-19006-error-bridging-integer-type: ecf752d54b05dd0a20f510f0bfa54a3fec3bcaca
1018-
refs/heads/rxwei-patch-1: 32d26eef13545c9411ee50cf1718c0f9d6df7980
1018+
refs/heads/rxwei-patch-1: 1e00633ac7dc84a7f048314af8aa592eff40aabf
10191019
refs/heads/shahmishal-patch-1: e58ec0f7488258d42bef51bc3e6d7b3dc74d7b2a
10201020
refs/heads/typelist-existential: 4046359efd541fb5c72d69a92eefc0a784df8f5e
10211021
refs/tags/swift-4.2-DEVELOPMENT-SNAPSHOT-2018-08-20-a: 4319ba09e4fb8650ee86061075c74a016b6baab9

branches/rxwei-patch-1/lib/Parse/ParseExpr.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3497,15 +3497,16 @@ void Parser::validateCollectionElement(ParserResult<Expr> element) {
34973497

34983498
auto startLocOfSubscript = subscriptExpr->getIndex()->getStartLoc();
34993499
auto endLocOfArray = arrayExpr->getEndLoc();
3500+
auto locForEndOfTokenArray = L->getLocForEndOfToken(SourceMgr, endLocOfArray);
35003501

3501-
if (L->getLocForEndOfToken(SourceMgr, endLocOfArray) != startLocOfSubscript) {
3502+
if (locForEndOfTokenArray != startLocOfSubscript) {
35023503
auto subscriptLoc = subscriptExpr->getLoc();
35033504
diagnose(subscriptLoc, diag::subscript_array_element)
35043505
.highlight(subscriptExpr->getSourceRange());
35053506
diagnose(subscriptLoc, diag::subscript_array_element_fix_it_add_comma)
35063507
.fixItInsertAfter(endLocOfArray, ",");
35073508
diagnose(subscriptLoc, diag::subscript_array_element_fix_it_remove_space)
3508-
.fixItRemoveChars(endLocOfArray.getAdvancedLoc(1), startLocOfSubscript);
3509+
.fixItRemoveChars(locForEndOfTokenArray, startLocOfSubscript);
35093510
}
35103511
}
35113512

0 commit comments

Comments
 (0)