Simplify conditional expression: (A && !B) || (!A && B) is equivalent to bool(A) != bool(B)

Author: valeriyvan

lib/Sema/CSSimplify.cpp

@@ -5645,8 +5645,7 @@ bool ConstraintSystem::repairFailures(
 
     auto *parentLoc = getConstraintLocator(anchor, path);
 
-    if ((lhs->is<InOutType>() && !rhs->is<InOutType>()) ||
-        (!lhs->is<InOutType>() && rhs->is<InOutType>())) {
+    if (bool(lhs->is<InOutType>()) != bool(rhs->is<InOutType>())) {
       // Since `FunctionArgument` as a last locator element represents
       // a single parameter of the function type involved in a conversion
       // to another function type, see `matchFunctionTypes`. If there is already