change naming & concretize diag message

Author: AnthonyLatsis

include/swift/AST/DiagnosticsSema.def

@@ -3209,8 +3209,8 @@ ERROR(unsupported_recursive_struct,none,
       "contains it",
       (Type))
 
-WARNING(type_not_constructible,none,
-        "value type is inconstructible", ())
+WARNING(enum_not_constructible,none,
+        "enum with recursive-only cases is not constructible", ())
 ERROR(recursive_enum_not_indirect,none,
       "recursive enum %0 is not marked 'indirect'", (Type))
 ERROR(unsupported_infinitely_sized_type,none,

lib/Sema/TypeCheckCircularity.cpp

@@ -169,7 +169,7 @@ class CircularityChecker {
   bool diagnoseInfiniteRecursion(CanType parentType, ValueDecl *member,
                                  CanType memberType);
 
-  void diagnoseInconstructible(EnumDecl *E);
+  void diagnoseNotConstructible(EnumDecl *E);
 
   void addPathElementsTo(Path &path, CanType type);
   void addPathElement(Path &path, ValueDecl *member, CanType memberType);
@@ -275,7 +275,7 @@ bool CircularityChecker::expandEnum(CanType type, EnumDecl *E,
                                    unsigned depth) {
   // Indirect enums are representational leaves.
   if (E->isIndirect()) {
-    diagnoseInconstructible(E);
+    diagnoseNotConstructible(E);
     return false;
   }
 
@@ -303,7 +303,7 @@ bool CircularityChecker::expandEnum(CanType type, EnumDecl *E,
     if (addMember(type, elt, eltType, depth))
       return true;
   }
-  diagnoseInconstructible(E);
+  diagnoseNotConstructible(E);
 
   return false;
 }
@@ -608,9 +608,9 @@ bool CircularityChecker::diagnoseInfiniteRecursion(CanType parentType,
   return true;
 }
 
-// Show a warning if the enum is inconstructible. The outcome of this method
-// is irrelevant.
-void CircularityChecker::diagnoseInconstructible(EnumDecl *E) {
+/// Show a warning if the enum is not constructible. The outcome of this method
+/// is irrelevant.
+void CircularityChecker::diagnoseNotConstructible(EnumDecl *E) {
 
   auto containsType = [](TupleType *tuple, Type E) -> bool {
     for (auto type: tuple->getElementTypes()) {
@@ -619,7 +619,7 @@ void CircularityChecker::diagnoseInconstructible(EnumDecl *E) {
     }
     return false;
   };
-  auto isInconstructible = [containsType, E]() -> bool {
+  auto isNotConstructible = [containsType, E]() -> bool {
     auto elts = E->getAllElements();
     if (elts.empty())
       return false;
@@ -644,6 +644,6 @@ void CircularityChecker::diagnoseInconstructible(EnumDecl *E) {
     return true;
   };
 
-  if (isInconstructible())
-    TC.diagnose(E, diag::type_not_constructible);
+  if (isNotConstructible())
+    TC.diagnose(E, diag::enum_not_constructible);
 }

test/Sema/unsupported_recursive_value_type.swift

@@ -42,21 +42,21 @@ enum RecursiveByGenericSubstitutionEnum<T> {
   case A(T)
 }
 
-enum InconstructibleEnum1 { // expected-warning {{value type is inconstructible}}
+enum InconstructibleEnum1 { // expected-warning {{enum with recursive-only cases is not constructible}}
   indirect case A(InconstructibleEnum1)
 }
 enum InconstructibleEnum2 { // OK
   indirect case A(InconstructibleEnum2)
   case B(Bool)
   indirect case C(Int, InconstructibleEnum2)
 }
-enum InconstructibleEnum3 { // expected-warning {{value type is inconstructible}}
+enum InconstructibleEnum3 { // expected-warning {{enum with recursive-only cases is not constructible}}
   indirect case B(Int, InconstructibleEnum3)
 }
-indirect enum InconstructibleEnum4 { // expected-warning {{value type is inconstructible}}
+indirect enum InconstructibleEnum4 { // expected-warning {{enum with recursive-only cases is not constructible}}
   case A(InconstructibleEnum4)
 }
-indirect enum InconstructibleEnum5 { // expected-warning {{value type is inconstructible}}
+indirect enum InconstructibleEnum5 { // expected-warning {{enum with recursive-only cases is not constructible}}
   case B(Int, InconstructibleEnum5)
 }
 indirect enum InconstructibleEnum6 { // OK