Merge pull request #71030 from tshortli/resolve-even-more-warnings

Resolve even more warnings

Author: tshortli

include/swift/ABI/Task.h

@@ -170,8 +170,8 @@ static_assert(alignof(Job) == 2 * alignof(void*),
 class NullaryContinuationJob : public Job {
 
 private:
-  AsyncTask* Task;
-  AsyncTask* Continuation;
+  SWIFT_ATTRIBUTE_UNUSED AsyncTask *Task;
+  AsyncTask *Continuation;
 
 public:
   NullaryContinuationJob(AsyncTask *task, JobPriority priority, AsyncTask *continuation)

include/swift/Basic/Compiler.h

@@ -98,6 +98,12 @@
 #define SWIFT_ATTRIBUTE_NORETURN
 #endif
 
+#if __has_attribute(unused)
+#define SWIFT_ATTRIBUTE_UNUSED __attribute__((__unused__))
+#else
+#define SWIFT_ATTRIBUTE_UNUSED
+#endif
+
 #ifndef SWIFT_BUG_REPORT_URL
 #define SWIFT_BUG_REPORT_URL "https://swift.org/contributing/#reporting-bugs"
 #endif

lib/CMakeLists.txt

@@ -19,8 +19,13 @@ list(APPEND LLVM_COMMON_DEPENDS intrinsics_gen clang-tablegen-targets)
 file(GENERATE
   OUTPUT "${CMAKE_CURRENT_BINARY_DIR}/HeaderDependencies.cpp"
   CONTENT "
+#ifndef COMPILED_WITH_SWIFT
 #define COMPILED_WITH_SWIFT
+#endif
+
+#ifndef SWIFT_TARGET
 #define SWIFT_TARGET
+#endif
 
 #include \"swift/Basic/BasicBridging.h\"
 #include \"swift/AST/ASTBridging.h\"

stdlib/public/Concurrency/Task.cpp

@@ -1635,6 +1635,8 @@ static void swift_task_asyncMainDrainQueueImpl() {
   swift_task_donateThreadToGlobalExecutorUntil([](void *context) {
     return *reinterpret_cast<bool*>(context);
   }, &Finished);
+  swift_unreachable(
+      "Returned from swift_task_donateThreadToGlobalExecutorUntil()");
 #elif !SWIFT_CONCURRENCY_ENABLE_DISPATCH
   // FIXME: consider implementing a concurrent global main queue for
   // these environments?

stdlib/toolchain/Compatibility56/Concurrency/TaskAlloc.cpp

@@ -41,7 +41,12 @@ static TaskAllocator &allocator(AsyncTask *task) {
   // FIXME: this fall-back shouldn't be necessary, but it's useful
   // for now, since the current execution tests aren't setting up a task
   // properly.
+
+  // https://github.com/apple/swift/issues/62761
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wexit-time-destructors"
   static GlobalAllocator global;
+#pragma clang diagnostic pop
   return global.allocator;
 }