Merge pull request #33721 from DougGregor/forward-scan-unresolved-member

[Constraint solver] Fix backward trailing closures with ".member" expressions

Author: DougGregor

lib/Sema/CSApply.cpp

@@ -5572,7 +5572,7 @@ Expr *ExprRewriter::coerceCallArguments(
     SmallVector<LocatorPathElt, 4> path;
     auto anchor = locator.getLocatorParts(path);
     if (!path.empty() && path.back().is<LocatorPathElt::ApplyArgument>() &&
-        (anchor.isExpr(ExprKind::Call) || anchor.isExpr(ExprKind::Subscript))) {
+        !anchor.isExpr(ExprKind::UnresolvedDot)) {
       auto locatorPtr = cs.getConstraintLocator(locator);
       assert(solution.trailingClosureMatchingChoices.count(locatorPtr) == 1);
       trailingClosureMatching = solution.trailingClosureMatchingChoices.find(

test/expr/postfix/call/forward_trailing_closure_unresolved_member.swift

@@ -0,0 +1,19 @@
+// RUN: %target-swift-emit-silgen %s | %FileCheck %s
+
+// rdar://problem/67781123 - crash in SILGen
+
+struct Foo {
+  var title: String
+  var handler1: ((Int, String) -> Void)?
+  var handler2: (() -> Void)?
+}
+
+func take(foo: Foo) { }
+
+// CHECK-LABEL: sil hidden [ossa] @$s42forward_trailing_closure_unresolved_member4testyy
+func test() {
+  // CHECK: function_ref @$s42forward_trailing_closure_unresolved_member4testyyFyycfU_ : $@convention(thin) () -> ()
+  take(foo: .init(title: "") {
+      print("handler2 is called")
+    })
+}