deprecations

Author: ktoso

lib/Sema/CodeSynthesisDistributedActor.cpp

@@ -693,7 +693,6 @@ static FuncDecl *createSameSignatureDistributedThunkDecl(DeclContext *DC,
                   /*parameterNameLoc=*/SourceLoc(), paramName, DC);
 
     paramDecl->setImplicit(true);
-    paramDecl->setSending();
     paramDecl->setSpecifier(funcParam->getSpecifier());
     paramDecl->setInterfaceType(funcParam->getInterfaceType());
 

stdlib/public/Concurrency/Task.cpp

@@ -735,22 +735,6 @@ swift_task_create_commonImpl(size_t rawTaskCreateFlags,
   /// FIXME: this is the fail path
   if (group) {
     assert(parent && "a task created in a group must be a child task");
-//
-//    // Prevent task-local misuse;
-//    // We must not allow an addTask {} wrapped immediately with a withValue {}
-//    auto ParentLocal = parent->_private().Local;
-//    if (auto taskLocalHeadLinkType = ParentLocal.peekHeadLinkType()) {
-//      if (taskLocalHeadLinkType ==
-//          swift::TaskLocal::NextLinkType::IsNextCreatedInTaskGroupBody) {
-//#if !SWIFT_CONCURRENCY_EMBEDDED
-//        swift_task_reportIllegalTaskLocalBindingWithinWithTaskGroup(
-//            nullptr, 0, true, 0);
-//#endif
-//        // TODO(ktoso): If we were to keep this crash mode; offer a better failure for embedded swift
-//        abort();
-//      }
-//    }
-//
     // Add to the task group, if requested.
     if (taskCreateFlags.addPendingGroupTaskUnconditionally()) {
       assert(group && "Missing group");

stdlib/public/Concurrency/TaskLocal.cpp

@@ -289,6 +289,9 @@ TaskLocal::Item::copyTo(AsyncTask *target) {
 // =============================================================================
 // ==== checks -----------------------------------------------------------------
 
+/// UNUSED: This is effectively not used anymore by new runtimes because we will
+/// defensively copy in this situation since Swift 6, rather than crash as a
+/// means of defence.
 SWIFT_CC(swift)
 static void swift_task_reportIllegalTaskLocalBindingWithinWithTaskGroupImpl(
     const unsigned char *_unused_file, uintptr_t _unused_fileLength,

stdlib/public/Concurrency/TaskLocal.swift

@@ -362,8 +362,9 @@ func _taskLocalsCopy(
 
 // ==== Checks -----------------------------------------------------------------
 
-@available(SwiftStdlib 5.1, *)
 @usableFromInline
+@available(SwiftStdlib 5.1, *)
+@available(*, deprecated, message: "The situation diagnosed by this is not handled gracefully rather than by crashing")
 func _checkIllegalTaskLocalBindingWithinWithTaskGroup(file: String, line: UInt) {
   if _taskHasTaskGroupStatusRecord() {
     file.withCString { _fileStart in
@@ -373,8 +374,9 @@ func _checkIllegalTaskLocalBindingWithinWithTaskGroup(file: String, line: UInt)
   }
 }
 
-@available(SwiftStdlib 5.1, *)
 @usableFromInline
+@available(SwiftStdlib 5.1, *)
+@available(*, deprecated, message: "The situation diagnosed by this is not handled gracefully rather than by crashing")
 @_silgen_name("swift_task_reportIllegalTaskLocalBindingWithinWithTaskGroup")
 func _reportIllegalTaskLocalBindingWithinWithTaskGroup(
   _ _filenameStart: UnsafePointer<Int8>,