Revert "[stdlib] Speculative workaround for ASAN failure"

Dave Abrahams · Dave Abrahams · commit b841f1eaa541 · 2016-08-04T13:59:15.000-07:00
This reverts commit dc86186. It didn't change anything.
diff --git a/stdlib/public/core/HashedCollections.swift.gyb b/stdlib/public/core/HashedCollections.swift.gyb
@@ -1265,14 +1265,8 @@ func _impossible<T>(_:T.Type) -> T {
 }
 
 func _unsafeUpcast<T, U>(_ x: T, to: U.Type) -> U {
-#if False
-  // disabled temporarily to speculatively work around a supposed optimizer bug
-  // that is triggering ASAN failures.
   _sanityCheck(x is U)
   return x as? U ?? _impossible(U.self)
-#else
-  return x as! U
-#endif
 }
 
 /// Perform a non-bridged upcast that always succeeds.

Original file line number	Diff line number	Diff line change
`@@ -1265,14 +1265,8 @@ func _impossible<T>(_:T.Type) -> T {`
`1265`	`1265`	`}`
`1266`	`1266`
`1267`	`1267`	`func _unsafeUpcast<T, U>(_ x: T, to: U.Type) -> U {`
`1268`		`-#if False`
`1269`		`- // disabled temporarily to speculatively work around a supposed optimizer bug`
`1270`		`- // that is triggering ASAN failures.`
`1271`	`1268`	`_sanityCheck(x is U)`
`1272`	`1269`	`return x as? U ?? _impossible(U.self)`
`1273`		`-#else`
`1274`		`- return x as! U`
`1275`		`-#endif`
`1276`	`1270`	`}`
`1277`	`1271`
`1278`	`1272`	`/// Perform a non-bridged upcast that always succeeds.`