build: check the compiler against the correct variable

compnerd · compnerd · commit b861bcc87bd6 · 2019-11-04T10:52:18.000-08:00
We were checking the compiler ID against the name of the compiler
binary.  This happened to pass incorrectly on Windows, which hid the
bug.
diff --git a/cmake/modules/AddSwift.cmake b/cmake/modules/AddSwift.cmake
@@ -1991,7 +1991,7 @@ function(add_swift_target_library name)
         DEPLOYMENT_VERSION_WATCHOS "${SWIFTLIB_DEPLOYMENT_VERSION_WATCHOS}"
         GYB_SOURCES ${SWIFTLIB_GYB_SOURCES}
       )
-    if(NOT SWIFT_BUILT_STANDALONE AND NOT CMAKE_C_COMPILER MATCHES Clang)
+    if(NOT SWIFT_BUILT_STANDALONE AND NOT "${CMAKE_C_COMPILER_ID}" MATCHES "Clang")
       add_dependencies(${VARIANT_NAME} clang)
     endif()
 

Original file line number	Diff line number	Diff line change
`@@ -1991,7 +1991,7 @@ function(add_swift_target_library name)`
`1991`	`1991`	`DEPLOYMENT_VERSION_WATCHOS "${SWIFTLIB_DEPLOYMENT_VERSION_WATCHOS}"`
`1992`	`1992`	`GYB_SOURCES ${SWIFTLIB_GYB_SOURCES}`
`1993`	`1993`	`)`
`1994`		`- if(NOT SWIFT_BUILT_STANDALONE AND NOT CMAKE_C_COMPILER MATCHES Clang)`
	`1994`	`+ if(NOT SWIFT_BUILT_STANDALONE AND NOT "${CMAKE_C_COMPILER_ID}" MATCHES "Clang")`
`1995`	`1995`	`add_dependencies(${VARIANT_NAME} clang)`
`1996`	`1996`	`endif()`
`1997`	`1997`