Merge pull request #19457 from rintaro/lexer-strliteral-interpolation-multiline

[Lexer] Fix assertion failure for unterminated string literal

Author: rintaro

lib/Parse/Lexer.cpp

@@ -1817,6 +1817,12 @@ void Lexer::lexStringLiteral(unsigned CustomDelimiterLen) {
         // Successfully scanned the body of the expression literal.
         ++CurPtr;
         continue;
+      } else if ((*CurPtr == '\r' || *CurPtr == '\n') && IsMultilineString) {
+        // The only case we reach here is unterminated single line string in the
+        // interpolation. For better recovery, go on after emitting an error.
+        diagnose(CurPtr, diag::lex_unterminated_string);
+        wasErroneous = true;
+        continue;
       }
 
       // Being diagnosed below.

test/Parse/multiline_errors.swift

@@ -184,3 +184,10 @@ _ = """\
   // FIXME: Bad diagnostics
   // expected-error@-3 {{multi-line string literal content must begin on a new line}}
   // expected-error@-4 {{escaped newline at the last line is not allowed}} {{8-9=}}
+
+let _ = """
+  foo
+  \("bar
+  baz
+  """
+  // expected-error@-3 {{unterminated string literal}}

test/Parse/string_literal_eof4.swift

@@ -0,0 +1,6 @@
+// RUN: %target-typecheck-verify-swift
+
+// NOTE: DO NOT add a newline at EOF.
+// expected-error@+1 {{unterminated string literal}}
+_ = """
+    foo

test/Parse/string_literal_eof5.swift

@@ -0,0 +1,7 @@
+// RUN: %target-typecheck-verify-swift
+
+// NOTE: DO NOT add a newline at EOF.
+// expected-error@+1 {{unterminated string literal}}
+_ = """
+    foo
+    \(

test/Parse/string_literal_eof6.swift

@@ -0,0 +1,7 @@
+// RUN: %target-typecheck-verify-swift
+
+// NOTE: DO NOT add a newline at EOF.
+// expected-error@+1 {{unterminated string literal}}
+_ = """
+    foo
+    \("bar

test/Parse/string_literal_eof7.swift

@@ -0,0 +1,9 @@
+// RUN: %target-typecheck-verify-swift
+
+// expected-error@+4 {{unterminated string literal}}
+// expected-error@+1 {{unterminated string literal}}
+_ = """
+    foo
+    \("bar
+    baz
+