Try to only remove comdata if the global is a declaration

aschwaighofer · aschwaighofer · commit ba1db4b82ba3 · 2023-05-26T10:22:53.000-07:00
diff --git a/lib/IRGen/GenDecl.cpp b/lib/IRGen/GenDecl.cpp
@@ -5180,7 +5180,8 @@ IRGenModule::getAddrOfTypeMetadata(CanType concreteType,
   }
 
   if (auto *GV = dyn_cast<llvm::GlobalVariable>(addr.getValue()))
-    GV->setComdat(nullptr);
+    if (GV->isDeclaration())
+      GV->setComdat(nullptr);
 
   // FIXME: MC breaks when emitting alias references on some platforms
   // (rdar://problem/22450593 ). Work around this by referring to the aliasee

Original file line number	Diff line number	Diff line change
`@@ -5180,7 +5180,8 @@ IRGenModule::getAddrOfTypeMetadata(CanType concreteType,`
`5180`	`5180`	`}`
`5181`	`5181`
`5182`	`5182`	`if (auto *GV = dyn_cast<llvm::GlobalVariable>(addr.getValue()))`
`5183`		`- GV->setComdat(nullptr);`
	`5183`	`+ if (GV->isDeclaration())`
	`5184`	`+ GV->setComdat(nullptr);`
`5184`	`5185`
`5185`	`5186`	`// FIXME: MC breaks when emitting alias references on some platforms`
`5186`	`5187`	`// (rdar://problem/22450593 ). Work around this by referring to the aliasee`