[CodeCompletion] Fix the mysteriously missing operators

In the experimental operator completion, we were mysteriously missing
some operators like ||.  It turns out it was all operators
alphabetically after '.', because the filtering code was very broken.

rdar://problem/23539465

Author: benlangmuir

test/SourceKit/CodeComplete/complete_operators.swift

@@ -1,6 +1,7 @@
 // RUN: %complete-test -tok=INT_OPERATORS %s | FileCheck %s
 // RUN: %complete-test -add-inner-results -tok=INT_OPERATORS_INNER %s | FileCheck %s -check-prefix=INNER
 // RUN: %complete-test -raw -hide-none -tok=INT_OPERATORS %s | FileCheck %s -check-prefix=RAW
+// RUN: %complete-test -tok=BOOL_OPERATORS %s | FileCheck %s -check-prefix=BOOL
 
 struct MyInt {
   var bigPowers: Int { return 1 }
@@ -47,3 +48,16 @@ func test2(var x: MyInt) {
 // RAW:   key.description: "++",
 // RAW:   key.typename: "MyInt",
 // RAW: },
+
+struct MyBool {
+  var foo: Int
+}
+func &&(x: MyBool, y: MyBool) -> MyBool { return x }
+func ||(x: MyBool, y: MyBool) -> MyBool { return x }
+
+func test3(x: MyBool) {
+  x#^BOOL_OPERATORS^#
+}
+// BOOL: .
+// BOOL: &&
+// BOOL: ||

tools/SourceKit/lib/SwiftLang/SwiftCompletion.cpp

@@ -858,18 +858,22 @@ static bool checkInnerResult(CodeCompletionResult *result, bool &hasDot,
   if (!chunks.empty() &&
       chunks[0].is(CodeCompletionString::Chunk::ChunkKind::Dot)) {
     hasDot = true;
+    return true;
   } else if (chunks.size() >= 2 &&
              chunks[0].is(
                  CodeCompletionString::Chunk::ChunkKind::QuestionMark) &&
              chunks[1].is(CodeCompletionString::Chunk::ChunkKind::Dot)) {
     hasQDot = true;
+    return true;
   } else if (result->getKind() ==
                  CodeCompletion::SwiftResult::ResultKind::Declaration &&
              result->getAssociatedDeclKind() ==
                  CodeCompletionDeclKind::Constructor) {
     hasInit = true;
+    return true;
+  } else {
+    return false;
   }
-  return hasInit || hasDot || hasQDot;
 }
 
 template <typename Result>