Skip to content

Commit ba3cc28

Browse files
committed
ABI Checker: avoid reporting module importation changes
ABI changes due to imported module changes should be reflected by other symbol changes. Reporting module import changes seems to be redundant.
1 parent 3b4d03c commit ba3cc28

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

lib/DriverTool/swift_api_digester_main.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -549,8 +549,7 @@ namespace {
549549

550550
static bool isMissingDeclAcceptable(const SDKNodeDecl *D) {
551551
// Don't complain about removing importation of SwiftOnoneSupport.
552-
if (D->getKind() == SDKNodeKind::DeclImport &&
553-
D->getName() == "SwiftOnoneSupport") {
552+
if (D->getKind() == SDKNodeKind::DeclImport) {
554553
return true;
555554
}
556555
return false;

test/api-digester/Outputs/apinotes-diags.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ APINotesTest(APINotesTest.h): TypeAlias CatAttributeName has been removed
1515
APINotesTest(APINotesTest.h): Protocol SwiftTypeWithMethodLeft has been renamed to Protocol SwiftTypeWithMethodRight
1616
APINotesTest(APINotesTest.h): Var OldType.oldMember has been renamed to Var NewType.newMember
1717
APINotesTest(APINotesTest.h): Var globalAttributeName has been renamed to Var AnimalAttributeName.globalAttributeName
18-
APINotesTest: Import Foundation has been renamed to Import objc_generics
1918

2019
/* Type Changes */
2120
APINotesTest(APINotesTest.h): Constructor Cat.init(name:) has return type change from APINotesTest.Cat to APINotesTest.Cat?

0 commit comments

Comments
 (0)