Replace reinterpret cast with struct

A single-element struct is structurally the same as the member type
itself.

Author: etcwilde

lib/SILGen/SILGenFunction.cpp

@@ -868,23 +868,14 @@ void SILGenFunction::emitAsyncMainThreadStart(SILDeclRef entryPoint) {
 
   B.setInsertionPoint(entryBlock);
 
-  /// Generates a reinterpret_cast for converting
-  /// Builtin.Job -> UnownedJob
-  /// Builtin.Executor -> UnownedSerialExecutor
-  /// These are used by _swiftJobRun, which, ABI-wise, could take
-  /// Builtin.Job or Builtin.Executor, but doesn't.
-  auto createExplodyCastForCall =
-      [this, &moduleLoc](SILValue originalValue, FuncDecl *jobRunFuncDecl,
-                         uint32_t paramIndex) -> SILValue {
-    // The type coming from the _swiftJobRun function
-    Type apiType = jobRunFuncDecl->getParameters()->get(paramIndex)->getType();
-    SILType apiSILType =
-        SILType::getPrimitiveObjectType(apiType->getCanonicalType());
+  auto wrapCallArgs = [this, &moduleLoc](SILValue originalValue, FuncDecl *fd,
+                            uint32_t paramIndex) -> SILValue {
+    Type parameterType = fd->getParameters()->get(paramIndex)->getType();
+    SILType paramSILType = SILType::getPrimitiveObjectType(parameterType->getCanonicalType());
     // If the types are the same, we don't need to do anything!
-    if (apiSILType == originalValue->getType())
+    if (paramSILType == originalValue->getType())
       return originalValue;
-    return this->B.createUncheckedReinterpretCast(moduleLoc, originalValue,
-                                                  apiSILType);
+    return this->B.createStruct(moduleLoc, paramSILType, originalValue);
   };
 
   // Call CreateAsyncTask
@@ -929,7 +920,7 @@ void SILGenFunction::emitAsyncMainThreadStart(SILDeclRef entryPoint) {
       moduleLoc,
       ctx.getIdentifier(getBuiltinName(BuiltinValueKind::ConvertTaskToJob)),
       JobType, {}, {task});
-  jobResult = createExplodyCastForCall(jobResult, swiftJobRunFuncDecl, 0);
+  jobResult = wrapCallArgs(jobResult, swiftJobRunFuncDecl, 0);
 
   // Get main executor
   FuncDecl *getMainExecutorFuncDecl = SGM.getGetMainExecutor();
@@ -939,7 +930,7 @@ void SILGenFunction::emitAsyncMainThreadStart(SILDeclRef entryPoint) {
   SILValue getMainExeutorFunc =
       B.createFunctionRefFor(moduleLoc, getMainExeutorSILFunc);
   SILValue mainExecutor = B.createApply(moduleLoc, getMainExeutorFunc, {}, {});
-  mainExecutor = createExplodyCastForCall(mainExecutor, swiftJobRunFuncDecl, 1);
+  mainExecutor = wrapCallArgs(mainExecutor, swiftJobRunFuncDecl, 1);
 
   // Run first part synchronously
   B.createApply(moduleLoc, swiftJobRunFunc, {}, {jobResult, mainExecutor});

test/Concurrency/async_main.swift

@@ -69,11 +69,11 @@ func asyncFunc() async {
 // CHECK-SIL-NEXT:  // function_ref swift_job_run
 // CHECK-SIL-NEXT:  %12 = function_ref @swift_job_run : $@convention(thin) (UnownedJob, UnownedSerialExecutor) -> ()
 // CHECK-SIL-NEXT:  %13 = builtin "convertTaskToJob"(%11 : $Builtin.NativeObject) : $Builtin.Job
-// CHECK-SIL-NEXT:  %14 = unchecked_trivial_bit_cast %13 : $Builtin.Job to $UnownedJob
+// CHECK-SIL-NEXT:  %14 = struct $UnownedJob (%13 : $Builtin.Job)
 // CHECK-SIL-NEXT:  // function_ref swift_task_getMainExecutor
 // CHECK-SIL-NEXT:  %15 = function_ref @swift_task_getMainExecutor : $@convention(thin) () -> Builtin.Executor
 // CHECK-SIL-NEXT:  %16 = apply %15() : $@convention(thin) () -> Builtin.Executor
-// CHECK-SIL-NEXT:  %17 = unchecked_trivial_bit_cast %16 : $Builtin.Executor to $UnownedSerialExecutor
+// CHECK-SIL-NEXT:  %17 = struct $UnownedSerialExecutor (%16 : $Builtin.Executor)
 // CHECK-SIL-NEXT:  %18 = apply %12(%14, %17) : $@convention(thin) (UnownedJob, UnownedSerialExecutor) -> ()
 // CHECK-SIL-NEXT:  // function_ref swift_task_asyncMainDrainQueue
 // CHECK-SIL-NEXT:  %19 = function_ref @swift_task_asyncMainDrainQueue : $@convention(thin) () -> Never