Skip to content

Commit bd32aa5

Browse files
committed
[stdlib] remove an extracting overload
- `RangeExpression` implicitly involves bounds checking, so this was misleading.
1 parent 712c79c commit bd32aa5

File tree

4 files changed

+2
-18
lines changed

4 files changed

+2
-18
lines changed

stdlib/public/core/Span/RawSpan.swift

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -415,14 +415,6 @@ extension RawSpan {
415415
///
416416
/// - Complexity: O(1)
417417
@unsafe
418-
@_alwaysEmitIntoClient
419-
@lifetime(self)
420-
public func _extracting(
421-
unchecked bounds: some RangeExpression<Int>
422-
) -> Self {
423-
unsafe _extracting(unchecked: bounds.relative(to: byteOffsets))
424-
}
425-
426418
@_alwaysEmitIntoClient
427419
@lifetime(self)
428420
public func _extracting(

stdlib/public/core/Span/Span.swift

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -583,14 +583,6 @@ extension Span where Element: ~Copyable {
583583
///
584584
/// - Complexity: O(1)
585585
@unsafe
586-
@_alwaysEmitIntoClient
587-
@lifetime(self)
588-
public func _extracting(
589-
unchecked bounds: some RangeExpression<Index>
590-
) -> Self {
591-
unsafe _extracting(unchecked: bounds.relative(to: indices))
592-
}
593-
594586
@_alwaysEmitIntoClient
595587
@lifetime(self)
596588
public func _extracting(

test/stdlib/Span/RawSpanTests.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ suite.test("_extracting() functions")
155155
let sub1 = span._extracting(0..<2)
156156
let sub2 = span._extracting(..<2)
157157
let sub3 = span._extracting(...)
158-
let sub4 = span._extracting(unchecked: 2...)
158+
let sub4 = span._extracting(2...)
159159

160160
sub1.withUnsafeBytes { p1 in
161161
sub2.withUnsafeBytes { p2 in

test/stdlib/Span/SpanTests.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -353,7 +353,7 @@ suite.test("_extracting() functions")
353353
let sub1 = span._extracting(0..<2)
354354
let sub2 = span._extracting(..<2)
355355
let sub3 = span._extracting(...)
356-
let sub4 = span._extracting(unchecked: 2...)
356+
let sub4 = span._extracting(2...)
357357
expectTrue(sub1._elementsEqual(sub2))
358358
expectTrue(sub3._elementsEqual(span))
359359
expectFalse(sub4._elementsEqual(sub3))

0 commit comments

Comments
 (0)