[CSDiagnostics] Update test cases.

Author: li3zhen1

lib/Sema/CSDiagnostics.cpp

@@ -8211,10 +8211,6 @@ bool UnableToInferGenericPackElementType::diagnoseAsError() {
     // specify contextual type for nil fix.
     emitDiagnostic(diag::unresolved_nil_literal);
   } else {
-    if (llvm::any_of(getSolution().Fixes, [&locator](const ConstraintFix *fix) {
-          return fix->getLocator() == locator;
-        }))
-      return false;
     // unable to infer the type of an element of generic pack params
     emitDiagnostic(diag::could_not_infer_pack_element,
                    packElementElt->getIndex());

test/Constraints/pack_expansion_types.swift

@@ -243,8 +243,10 @@ func patternInstantiationConcreteValid() {
 func patternInstantiationConcreteInvalid() {
   let _: Set<Int> = patternInstantiationTupleTest1()
   // expected-error@-1 {{cannot convert value of type '(repeat Array<_>)' to specified type 'Set<Int>'}}
+  // expected-error@-2 {{could not infer pack element #0 from context}}
 
   let _: (Array<Int>, Set<String>) = patternInstantiationTupleTest1() // expected-error {{'(repeat Array<Int, _>)' is not convertible to '(Array<Int>, Set<String>)', tuples have a different number of elements}}
+  // expected-error@-1 {{could not infer pack element #1 from context}}
 }
 
 func patternInstantiationGenericValid<each T, each U>(t: repeat each T, u: repeat each U)
@@ -275,6 +277,7 @@ func patternInstantiationGenericInvalid<each T: Hashable>(t: repeat each T) {
   // expected-error@-1 {{generic parameter 'each T' could not be inferred}}
 
   let _: (repeat Array<each T>, Set<String>) = patternInstantiationTupleTest1() // expected-error {{'(repeat Array<repeat each T, _>)' is not convertible to '(repeat Array<each T>, Set<String>)', tuples have a different number of elements}}
+  // expected-error@-1 {{could not infer pack element #1 from context}}
 }
 
 // rdar://107996926 - Vanishing metatype of tuple not supported