Skip to content

Commit bef0657

Browse files
committed
Merge pull request #244 from mohammadg/dev
Remove unnecessary 'visitDecl' default cases.
2 parents 8d835de + ee2ceca commit bef0657

File tree

2 files changed

+0
-7
lines changed

2 files changed

+0
-7
lines changed

tools/SourceKit/lib/SwiftLang/SwiftLangSupport.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -156,9 +156,6 @@ class UIdentVisitor : public ASTVisitor<UIdentVisitor,
156156
public:
157157
explicit UIdentVisitor(bool IsRef) : IsRef(IsRef) { }
158158

159-
/// TODO: reconsider whether having a default case is a good idea.
160-
UIdent visitDecl(const Decl *D) { return UIdent(); }
161-
162159
UIdent visitFuncDecl(const FuncDecl *D);
163160
UIdent visitVarDecl(const VarDecl *D);
164161
UIdent visitExtensionDecl(const ExtensionDecl *D);

tools/swift-ide-test/ModuleAPIDiff.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -782,10 +782,6 @@ class SMAModelGenerator : public DeclVisitor<SMAModelGenerator> {
782782
return Result;
783783
}
784784

785-
void visitDecl(Decl *D) {
786-
// FIXME: maybe don't have a default case
787-
}
788-
789785
void visitStructDecl(StructDecl *SD) {
790786
auto ResultSD = std::make_shared<sma::StructDecl>();
791787
ResultSD->Name = convertToIdentifier(SD->getName());

0 commit comments

Comments
 (0)