Skip to content

Commit bf0cfc5

Browse files
committed
[frontend] Address feedback by Jordan
1 parent 5732b25 commit bf0cfc5

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

lib/AST/DiagnosticEngine.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,7 @@ bool DiagnosticEngine::isDiagnosticPointsToFirstBadToken(DiagID ID) const {
250250
bool DiagnosticEngine::finishProcessing() {
251251
bool hadError = false;
252252
for (auto &Consumer : Consumers) {
253-
hadError = Consumer->finishProcessing() || hadError;
253+
hadError |= Consumer->finishProcessing();
254254
}
255255
return hadError;
256256
}

lib/FrontendTool/FrontendTool.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -341,7 +341,7 @@ class JSONFixitWriter
341341
DiagnosticEngine DE(dummyMgr);
342342
PrintingDiagnosticConsumer PDC;
343343
DE.addConsumer(PDC);
344-
DE.diagnose(SourceLoc(), diag::cannot_open_serialized_file,
344+
DE.diagnose(SourceLoc(), diag::cannot_open_file,
345345
FixitsOutputPath, EC.message());
346346
return true;
347347
}

0 commit comments

Comments
 (0)