Merge pull request #25637 from brentdax/nested-private-witness-crasher-5.1

[5.1] [Runtime] Fix private generic type witness demangling failure

Author: beccadax

stdlib/public/runtime/MetadataLookup.cpp

@@ -1677,12 +1677,13 @@ buildDescriptorPath(const ContextDescriptor *context) const {
       hasNonKeyGenericParams = true;
   }
 
-  // Form the path element.
-  descriptorPath.push_back(PathElement{localGenericParams,
-                                       context->getNumGenericParams(),
-                                       numKeyGenericParamsInParent,
-                                       numKeyGenericParamsHere,
-                                       hasNonKeyGenericParams});
+  // Form the path element if there are any generic parameters to be found.
+  if (numKeyGenericParamsHere != 0)
+    descriptorPath.push_back(PathElement{localGenericParams,
+                                         context->getNumGenericParams(),
+                                         numKeyGenericParamsInParent,
+                                         numKeyGenericParamsHere,
+                                         hasNonKeyGenericParams});
   return numKeyGenericParamsInParent + numKeyGenericParamsHere;
 }
 

test/Runtime/associated_type_demangle_private.swift

@@ -73,5 +73,46 @@ AssociatedTypeDemangleTests.test("generic anonymous contexts") {
   expectEqual("Inner<Int>", String(describing: getP2_A(C3<Int>.self)))
 }
 
+// rdar://problem/47773183
+struct Pair<First, Second> {
+  var first: First
+  var second: Second
+}
+
+protocol PairConvertible {
+  associatedtype First
+  associatedtype Second
+  associatedtype PairType = Pair<First, Second>
+
+  var first: First { get }
+  var second: Second { get }
+}
+
+extension PairConvertible where PairType == Pair<First, Second> {
+  var pair: PairType { Pair(first: first, second: second) }
+}
+
+private struct Parent<Unused> {
+  struct Nested<First, Second>: PairConvertible {
+    var first: First
+    var second: Second
+  }
+}
+
+AssociatedTypeDemangleTests.test("nested private generic types in associated type witnesses") {
+  // Fixed in custom runtimes.
+  if #available(macOS 9999, iOS 9999, tvOS 9999, watchOS 9999, * ) {}
+  // Fixed in Swift 5.1+ runtimes.
+  else if #available(macOS 10.15, iOS 13, tvOS 13, watchOS 6, *) {}
+  // Bug is still present in Swift 5.0 runtime.
+  else {
+    // FIXME: rdar://problem/51959305
+    // expectCrashLater(withMessage: "failed to demangle witness for associated type 'Second' in conformance")
+    return
+  }
+
+  _ = Parent<Never>.Nested(first: "String", second: 0).pair
+}
+
 
 runAllTests()