Skip to content

Commit c1fa7db

Browse files
DougGregorDougGregor
authored
Merge pull request #78030 from DougGregor/custom-attribute-initializer-declcontext
2 parents f1f1051 + e210b10 commit c1fa7db

21 files changed

+158
-124
lines changed

‎include/swift/AST/ASTBridging.h

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -536,6 +536,14 @@ SWIFT_NAME("getter:BridgedPatternBindingInitializer.asDeclContext(self:)")
536536
BridgedDeclContext BridgedPatternBindingInitializer_asDeclContext(
537537
BridgedPatternBindingInitializer cInit);
538538

539+
SWIFT_NAME("BridgedCustomAttributeInitializer.create(declContext:)")
540+
BridgedCustomAttributeInitializer
541+
BridgedCustomAttributeInitializer_create(BridgedDeclContext cDeclContext);
542+
543+
SWIFT_NAME("getter:BridgedCustomAttributeInitializer.asDeclContext(self:)")
544+
BridgedDeclContext BridgedCustomAttributeInitializer_asDeclContext(
545+
BridgedCustomAttributeInitializer cInit);
546+
539547
SWIFT_NAME("getter:BridgedClosureExpr.asDeclContext(self:)")
540548
BridgedDeclContext
541549
BridgedClosureExpr_asDeclContext(BridgedClosureExpr cClosure);
@@ -613,7 +621,7 @@ SWIFT_NAME(
613621
"BridgedCustomAttr.createParsed(_:atLoc:type:initContext:argumentList:)")
614622
BridgedCustomAttr BridgedCustomAttr_createParsed(
615623
BridgedASTContext cContext, BridgedSourceLoc cAtLoc, BridgedTypeRepr cType,
616-
BridgedNullablePatternBindingInitializer cInitContext,
624+
BridgedNullableCustomAttributeInitializer cInitContext,
617625
BridgedNullableArgumentList cArgumentList);
618626

619627
SWIFT_NAME("BridgedDocumentationAttr.createParsed(_:atLoc:range:metadata:"

‎include/swift/AST/ASTBridgingWrappers.def

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ AST_BRIDGING_WRAPPER_NULLABLE(GenericParamList)
8383
AST_BRIDGING_WRAPPER_NULLABLE(TrailingWhereClause)
8484
AST_BRIDGING_WRAPPER_NULLABLE(ParameterList)
8585
AST_BRIDGING_WRAPPER_NULLABLE(PatternBindingInitializer)
86+
AST_BRIDGING_WRAPPER_NULLABLE(CustomAttributeInitializer)
8687
AST_BRIDGING_WRAPPER_NONNULL(TypeAttributes)
8788
AST_BRIDGING_WRAPPER_NONNULL(CustomAttribute)
8889
AST_BRIDGING_WRAPPER_NULLABLE(ArgumentList)

‎include/swift/AST/Attr.h

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ class AbstractFunctionDecl;
6060
class FuncDecl;
6161
class ClassDecl;
6262
class AccessorDecl;
63+
class CustomAttributeInitializer;
6364
class GenericFunctionType;
6465
class LazyConformanceLoader;
6566
class LazyMemberLoader;
@@ -1861,13 +1862,13 @@ class ClangImporterSynthesizedTypeAttr : public DeclAttribute {
18611862
class CustomAttr final : public DeclAttribute {
18621863
TypeExpr *typeExpr;
18631864
ArgumentList *argList;
1864-
PatternBindingInitializer *initContext;
1865+
CustomAttributeInitializer *initContext;
18651866
Expr *semanticInit = nullptr;
18661867

18671868
mutable unsigned isArgUnsafeBit : 1;
18681869

18691870
CustomAttr(SourceLoc atLoc, SourceRange range, TypeExpr *type,
1870-
PatternBindingInitializer *initContext, ArgumentList *argList,
1871+
CustomAttributeInitializer *initContext, ArgumentList *argList,
18711872
bool implicit);
18721873

18731874
public:
@@ -1878,7 +1879,7 @@ class CustomAttr final : public DeclAttribute {
18781879
}
18791880

18801881
static CustomAttr *create(ASTContext &ctx, SourceLoc atLoc, TypeExpr *type,
1881-
PatternBindingInitializer *initContext,
1882+
CustomAttributeInitializer *initContext,
18821883
ArgumentList *argList, bool implicit = false);
18831884

18841885
TypeExpr *getTypeExpr() const { return typeExpr; }
@@ -1911,7 +1912,7 @@ class CustomAttr final : public DeclAttribute {
19111912
Expr *getSemanticInit() const { return semanticInit; }
19121913
void setSemanticInit(Expr *expr) { semanticInit = expr; }
19131914

1914-
PatternBindingInitializer *getInitContext() const { return initContext; }
1915+
CustomAttributeInitializer *getInitContext() const { return initContext; }
19151916

19161917
static bool classof(const DeclAttribute *DA) {
19171918
return DA->getKind() == DeclAttrKind::Custom;

‎include/swift/AST/Initializer.h

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,10 @@
2222

2323
#include "swift/AST/DeclContext.h"
2424

25+
namespace llvm {
26+
class raw_ostream;
27+
}
28+
2529
namespace swift {
2630
class ParamDecl;
2731
class PatternBindingDecl;
@@ -36,6 +40,9 @@ enum class InitializerKind : uint8_t {
3640

3741
/// A property wrapper initialization expression.
3842
PropertyWrapper,
43+
44+
/// An expression within a custom attribute.
45+
CustomAttribute,
3946
};
4047

4148
/// An Initializer is a kind of DeclContext used for expressions that
@@ -176,6 +183,34 @@ class PropertyWrapperInitializer : public Initializer {
176183
}
177184
};
178185

186+
/// An expression within a custom attribute. The parent context is the
187+
/// context in which the attributed declaration occurs.
188+
class CustomAttributeInitializer : public Initializer {
189+
public:
190+
explicit CustomAttributeInitializer(DeclContext *parent)
191+
: Initializer(InitializerKind::CustomAttribute, parent) {}
192+
193+
static CustomAttributeInitializer *create(DeclContext *parent) {
194+
return new (parent->getASTContext()) CustomAttributeInitializer(parent);
195+
}
196+
197+
void setEnclosingInitializer(Initializer *newParent) {
198+
setParent(newParent);
199+
}
200+
201+
static bool classof(const DeclContext *DC) {
202+
if (auto init = dyn_cast<Initializer>(DC))
203+
return classof(init);
204+
return false;
205+
}
206+
207+
static bool classof(const Initializer *I) {
208+
return I->getInitializerKind() == InitializerKind::CustomAttribute;
209+
}
210+
};
211+
212+
void simple_display(llvm::raw_ostream &out, Initializer *init);
213+
179214
} // end namespace swift
180215

181216
#endif

‎include/swift/Parse/Parser.h

Lines changed: 2 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -998,8 +998,7 @@ class Parser {
998998

999999
/// Parse an #if ... #endif containing only attributes.
10001000
ParserStatus parseIfConfigAttributes(
1001-
DeclAttributes &attributes, bool ifConfigsAreDeclAttrs,
1002-
PatternBindingInitializer *initContext);
1001+
DeclAttributes &attributes, bool ifConfigsAreDeclAttrs);
10031002

10041003
/// Parse a #error or #warning diagnostic.
10051004
ParserResult<PoundDiagnosticDecl> parseDeclPoundDiagnostic();
@@ -1022,13 +1021,6 @@ class Parser {
10221021
ParserStatus parseDeclAttributeList(DeclAttributes &Attributes,
10231022
bool IfConfigsAreDeclAttrs = false);
10241023

1025-
/// Parse the optional attributes before a declaration.
1026-
///
1027-
/// This is the inner loop, which can be called recursively.
1028-
ParserStatus parseDeclAttributeList(DeclAttributes &Attributes,
1029-
bool IfConfigsAreDeclAttrs,
1030-
PatternBindingInitializer *initContext);
1031-
10321024
/// Parse the optional attributes before a closure declaration.
10331025
ParserStatus parseClosureDeclAttributeList(DeclAttributes &Attributes);
10341026

@@ -1162,7 +1154,6 @@ class Parser {
11621154
/// Parse a specific attribute.
11631155
ParserStatus parseDeclAttribute(DeclAttributes &Attributes, SourceLoc AtLoc,
11641156
SourceLoc AtEndLoc,
1165-
PatternBindingInitializer *&initContext,
11661157
bool isFromClangAttribute = false);
11671158

11681159
bool isCustomAttributeArgument();
@@ -1171,13 +1162,7 @@ class Parser {
11711162
/// Parse a custom attribute after the initial '@'.
11721163
///
11731164
/// \param atLoc The location of the already-parsed '@'.
1174-
///
1175-
/// \param initContext A reference to the initializer context used
1176-
/// for the set of custom attributes. This should start as nullptr, and
1177-
/// will get filled in by this function. The same variable should be provided
1178-
/// for every custom attribute within the same attribute list.
1179-
ParserResult<CustomAttr> parseCustomAttribute(
1180-
SourceLoc atLoc, PatternBindingInitializer *&initContext);
1165+
ParserResult<CustomAttr> parseCustomAttribute(SourceLoc atLoc);
11811166

11821167
ParserStatus parseNewDeclAttribute(DeclAttributes &Attributes,
11831168
SourceLoc AtLoc, DeclAttrKind DK,
@@ -1479,7 +1464,6 @@ class Parser {
14791464

14801465
ParserStatus parseTypeAttribute(TypeOrCustomAttr &result, SourceLoc AtLoc,
14811466
SourceLoc AtEndLoc, ParseTypeReason reason,
1482-
PatternBindingInitializer *&initContext,
14831467
bool justChecking = false);
14841468

14851469
ParserResult<TypeRepr> parseOldStyleProtocolComposition();

‎lib/AST/ASTDumper.cpp

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1911,17 +1911,7 @@ void swift::printContext(raw_ostream &os, DeclContext *dc) {
19111911
break;
19121912

19131913
case DeclContextKind::Initializer:
1914-
switch (cast<Initializer>(dc)->getInitializerKind()) {
1915-
case InitializerKind::PatternBinding:
1916-
os << "pattern binding initializer";
1917-
break;
1918-
case InitializerKind::DefaultArgument:
1919-
os << "default argument initializer";
1920-
break;
1921-
case InitializerKind::PropertyWrapper:
1922-
os << "property wrapper initializer";
1923-
break;
1924-
}
1914+
simple_display(os, cast<Initializer>(dc));
19251915
break;
19261916

19271917
case DeclContextKind::TopLevelCodeDecl:

‎lib/AST/ASTMangler.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2541,6 +2541,12 @@ void ASTMangler::appendContext(const DeclContext *ctx,
25412541
}
25422542
return;
25432543
}
2544+
2545+
case InitializerKind::CustomAttribute: {
2546+
BaseEntitySignature nullBase(nullptr);
2547+
appendContext(ctx->getParent(), nullBase, useModuleName);
2548+
return;
2549+
}
25442550
}
25452551
llvm_unreachable("bad initializer kind");
25462552
}

‎lib/AST/Attr.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2632,7 +2632,7 @@ ProtocolDecl *ImplementsAttr::getProtocol(DeclContext *dc) const {
26322632
}
26332633

26342634
CustomAttr::CustomAttr(SourceLoc atLoc, SourceRange range, TypeExpr *type,
2635-
PatternBindingInitializer *initContext,
2635+
CustomAttributeInitializer *initContext,
26362636
ArgumentList *argList, bool implicit)
26372637
: DeclAttribute(DeclAttrKind::Custom, atLoc, range, implicit),
26382638
typeExpr(type), argList(argList), initContext(initContext) {
@@ -2641,7 +2641,7 @@ CustomAttr::CustomAttr(SourceLoc atLoc, SourceRange range, TypeExpr *type,
26412641
}
26422642

26432643
CustomAttr *CustomAttr::create(ASTContext &ctx, SourceLoc atLoc, TypeExpr *type,
2644-
PatternBindingInitializer *initContext,
2644+
CustomAttributeInitializer *initContext,
26452645
ArgumentList *argList, bool implicit) {
26462646
assert(type);
26472647
SourceRange range(atLoc, type->getSourceRange().End);

‎lib/AST/Bridging/DeclAttributeBridging.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ BridgedCDeclAttr BridgedCDeclAttr_createParsed(BridgedASTContext cContext,
134134

135135
BridgedCustomAttr BridgedCustomAttr_createParsed(
136136
BridgedASTContext cContext, BridgedSourceLoc cAtLoc, BridgedTypeRepr cType,
137-
BridgedNullablePatternBindingInitializer cInitContext,
137+
BridgedNullableCustomAttributeInitializer cInitContext,
138138
BridgedNullableArgumentList cArgumentList) {
139139
ASTContext &context = cContext.unbridged();
140140
return CustomAttr::create(

‎lib/AST/Bridging/DeclContextBridging.cpp

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,16 @@ BridgedDeclContext BridgedPatternBindingInitializer_asDeclContext(
3131
return cInit.unbridged();
3232
}
3333

34+
BridgedCustomAttributeInitializer
35+
BridgedCustomAttributeInitializer_create(BridgedDeclContext cDeclContext) {
36+
return CustomAttributeInitializer::create(cDeclContext.unbridged());
37+
}
38+
39+
BridgedDeclContext BridgedCustomAttributeInitializer_asDeclContext(
40+
BridgedCustomAttributeInitializer cInit) {
41+
return cInit.unbridged();
42+
}
43+
3444
BridgedDeclContext
3545
BridgedClosureExpr_asDeclContext(BridgedClosureExpr cClosure) {
3646
return cClosure.unbridged();

‎lib/AST/Decl.cpp

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2061,8 +2061,17 @@ PatternBindingDecl::create(ASTContext &Ctx, SourceLoc StaticLoc,
20612061
// FIXME: We ought to reconsider this since it won't recontextualize any
20622062
// closures/decls present in the initialization expr. This currently should
20632063
// only affect implicit code though.
2064-
if (!initContext && !Parent->isLocalContext())
2064+
if (!initContext && !Parent->isLocalContext()) {
20652065
initContext = PatternBindingInitializer::create(Parent);
2066+
}
2067+
2068+
// Set up the custom attribute contexts for each variable in this pattern.
2069+
PBD->getPattern(idx)->forEachVariable([&](VarDecl *var) {
2070+
for (auto custom : var->getAttrs().getAttributes<CustomAttr>()) {
2071+
if (auto attributeInit = custom->getInitContext())
2072+
attributeInit->setEnclosingInitializer(initContext);
2073+
}
2074+
});
20662075

20672076
// We need to call setPattern to ensure the VarDecls in the pattern have
20682077
// the PatternBindingDecl set as their parent. We also need to call

‎lib/AST/DeclContext.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -869,6 +869,9 @@ unsigned DeclContext::printContext(raw_ostream &OS, const unsigned indent,
869869
}
870870
break;
871871
}
872+
case InitializerKind::CustomAttribute:
873+
OS << " CustomAttribute";
874+
break;
872875
}
873876
break;
874877
}

‎lib/AST/TypeCheckRequests.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1470,6 +1470,9 @@ void swift::simple_display(llvm::raw_ostream &out, Initializer *init) {
14701470
case InitializerKind::PropertyWrapper:
14711471
out << "property wrapper initializer";
14721472
break;
1473+
case InitializerKind::CustomAttribute:
1474+
out << "custom attribute initializer";
1475+
break;
14731476
}
14741477
}
14751478

‎lib/ASTGen/Sources/ASTGen/Bridge.swift

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ extension BridgedNullableGenericParamList: /*@retroactive*/ swiftASTGen.BridgedN
3434
extension BridgedNullableTrailingWhereClause: /*@retroactive*/ swiftASTGen.BridgedNullable {}
3535
extension BridgedNullableParameterList: /*@retroactive*/ swiftASTGen.BridgedNullable {}
3636
extension BridgedNullablePatternBindingInitializer: /*@retroactive*/ swiftASTGen.BridgedNullable {}
37+
extension BridgedNullableCustomAttributeInitializer: /*@retroactive*/ swiftASTGen.BridgedNullable {}
3738
extension BridgedNullableArgumentList: /*@retroactive*/ swiftASTGen.BridgedNullable {}
3839

3940
extension BridgedIdentifier: /*@retroactive*/ Swift.Equatable {
@@ -80,6 +81,9 @@ extension BridgedParameterList: BridgedHasNullable {
8081
extension BridgedPatternBindingInitializer: BridgedHasNullable {
8182
typealias Nullable = BridgedNullablePatternBindingInitializer
8283
}
84+
extension BridgedCustomAttributeInitializer: BridgedHasNullable {
85+
typealias Nullable = BridgedNullableCustomAttributeInitializer
86+
}
8387
extension BridgedArgumentList: BridgedHasNullable {
8488
typealias Nullable = BridgedNullableArgumentList
8589
}

0 commit comments

Comments
 (0)