Skip to content

Commit c1fcdc4

Browse files
committed
Gardening: Migrate test suite to GH issues: Serialization
1 parent 04f1cde commit c1fcdc4

10 files changed

+20
-16
lines changed

test/Serialization/Inputs/def_property_wrappers.swift

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@ public struct HasWrappers {
1919
@SomeWrapper public var x: Int = 17
2020
}
2121

22-
// SR-10844
22+
// https://github.com/apple/swift/issues/53234
23+
2324
@propertyWrapper
2425
class A<T: Equatable> {
2526

test/Serialization/Inputs/use_imported_enums.swift

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ import Foundation
88
return compareToSelf(e)
99
}
1010

11-
// SR-6105
11+
// https://github.com/apple/swift/issues/48660
12+
1213
open class EVC<EnumType : EVT> where EnumType.RawValue : Hashable {
1314
}
1415

test/Serialization/inherited-initializer.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ func testGeneric() {
3636
// CHECK: apply [[DEFAULT]]<Reinitializable<Int8>>({{%.+}})
3737
// CHECK: [[INIT:%.+]] = function_ref @$s4main10GenericSubCyACyxGxcfC
3838
// CHECK: apply [[INIT]]<Reinitializable<Int8>>({{%.+}}, [[TYPE]])
39-
_ = GenericSub<Reinitializable<Int8>>.init() // works around SR-3806
39+
_ = GenericSub<Reinitializable<Int8>>.init() // works around https://github.com/apple/swift/issues/46391
4040

4141
// CHECK: [[TYPE:%.+]] = metatype $@thick ModifiedGenericSub<Int16>.Type
4242
// CHECK: [[DEFAULT:%.+]] = function_ref @$s24InheritedInitializerBase07GenericC0CyACyxGxcfcfA_

test/Serialization/load-target-normalization.swift

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
// RUN: %empty-directory(%t/ForeignModule.swiftmodule)
22
// RUN: touch %t/ForeignModule.swiftmodule/garbage-garbage-garbage.swiftmodule
33

4-
// SR-12363: This test crashes on next branch.
4+
// https://github.com/apple/swift/issues/54797
5+
// This test crashes on 'next' branch.
56
// XFAIL: asserts
67

78
// Test format: We try to import ForeignModule with architectures besides

test/Serialization/multi-file-subclass-generic-instantiation.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
// RUN: %target-build-swift -emit-module -o %t/Module.swiftmodule %s %S/Inputs/multi-file-subclass-generic-instantiation-extension.swift
44

5-
// https://bugs.swift.org/browse/SR-11495
5+
// https://github.com/apple/swift/issues/53896
66

77
class Superclass<T> {}
88
class Subclass: Superclass<Subclass.MemberTypeFromOtherFile> {}

test/Serialization/multi-file.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ struct StructWithInheritedConformances: Sequence {
4242
}
4343
}
4444

45-
// https://bugs.swift.org/browse/SR-2576
45+
// https://github.com/apple/swift/issues/45181
4646
// An associated type inside a private protocol would cause crashes during
4747
// module merging.
4848
private protocol SomeProto {

test/Serialization/objc_optional_reqs.swift

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@
1010

1111
// REQUIRES: objc_interop
1212

13-
// SR-3917
13+
// https://github.com/apple/swift/issues/46502
14+
1415
import def_objc_conforming
1516

1617
func test(x: Foo) { _ = x.badness }

test/Serialization/property_wrappers.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66

77
@testable import def_property_wrappers
88

9-
// SR-10844
10-
func testSR10844() {
9+
// https://github.com/apple/swift/issues/53234
10+
do {
1111
let holder = Holder()
1212
holder.b = 100
1313
}

test/Serialization/runtime-import-from-sdk.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747

4848
// FIXME: We can't properly test this on a non-Darwin platform because we'll get
4949
// the same error message for "unloadable standard library" and "no standard
50-
// library". (SR-10097)
50+
// library" (https://github.com/apple/swift/issues/52499).
5151
// REQUIRES: objc_interop
5252

5353
// RUN: %empty-directory(%t/mcp)

test/Serialization/xref-private-type.swift

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55

66
import Lib
77

8-
// CHECK: sil{{.*}} @[[TESTSR6874:[^ ]+10testSR6874[^ ]+]] :
9-
func testSR6874() {
8+
// CHECK: sil{{.*}} @[[TEST1:[^ ]+5test1[^ ]+]] :
9+
func test1() {
1010
// The important lines in this test are the strong_retains, which refer to
1111
// private types defined in LibCore. Normally we shouldn't have references to
1212
// non-public declarations in inlinable code, but because SIL passes can break
@@ -20,9 +20,9 @@ func testSR6874() {
2020
// reference a private type, but to *resolve a cross-reference to a private
2121
// type.*
2222
//
23-
// This is the situation in SR-6874 (simplified). I'm not sure of a simpler
24-
// way to reliably trigger the issue. But if this test breaks, please try to
25-
// find one.
23+
// This is the situation in https://github.com/apple/swift/issues/49423
24+
// (simplified). I'm not sure of a simpler way to reliably trigger the issue.
25+
// But if this test breaks, please try to find one.
2626
//
2727
// (We may want to revisit this whole thing later, as it violates the model.
2828
// But it's also useful for performance in non-resilient code.)
@@ -47,5 +47,5 @@ func testSR6874() {
4747
// CHECK: strong_retain [[REF]] : $Baz.NestedInternalClass.DoublyNestedInternalClass
4848
// CHECK: apply {{%.+}}([[LOADED]])
4949
testBaz()
50-
} // CHECK: end sil function '[[TESTSR6874]]'
50+
} // CHECK: end sil function '[[TEST1]]'
5151

0 commit comments

Comments
 (0)