[overlay] Potentially better bridging to NSString in StringProtocol extensions

Max Moiseev · Max Moiseev · commit c2476f4ddbf6 · 2017-07-13T15:01:24.000-07:00
(cherry picked from commit 77edc65)
diff --git a/stdlib/public/SDK/Foundation/NSStringAPI.swift b/stdlib/public/SDK/Foundation/NSStringAPI.swift
@@ -414,7 +414,7 @@ extension StringProtocol where Index == String.Index {
   /// The corresponding `NSString` - a convenience for bridging code.
   // FIXME(strings): There is probably a better way to bridge Self to NSString
   var _ns: NSString {
-    return String(self) as NSString
+    return self._ephemeralString as NSString
   }
 
   /// Return an `Index` corresponding to the given offset in our UTF-16

Original file line number	Diff line number	Diff line change
`@@ -414,7 +414,7 @@ extension StringProtocol where Index == String.Index {`
`414`	`414`	/// The corresponding `NSString` - a convenience for bridging code.
`415`	`415`	`// FIXME(strings): There is probably a better way to bridge Self to NSString`
`416`	`416`	`var _ns: NSString {`
`417`		`- return String(self) as NSString`
	`417`	`+ return self._ephemeralString as NSString`
`418`	`418`	`}`
`419`	`419`
`420`	`420`	/// Return an `Index` corresponding to the given offset in our UTF-16