Fix incorrect SILSuccessorIterator operator++ that broke master-next after llvm r294339.

bob-wilson · bob-wilson · commit c24c9958c007 · 2017-02-10T22:22:29.000-08:00
This operator++ is a post-increment operator but it was implemented with pre-increment behavior.
This bug was exposed by the changes in llvm r294339 and caused the master-next branch to stop
building.
diff --git a/include/swift/SIL/SILSuccessor.h b/include/swift/SIL/SILSuccessor.h
@@ -88,7 +88,7 @@ class SILSuccessorIterator {
 
   SILSuccessorIterator operator++(int) {
     SILSuccessorIterator copy = *this;
-    ++copy;
+    ++*this;
     return copy;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ class SILSuccessorIterator {`
`88`	`88`
`89`	`89`	`SILSuccessorIterator operator++(int) {`
`90`	`90`	`SILSuccessorIterator copy = *this;`
`91`		`- ++copy;`
	`91`	`+ ++*this;`
`92`	`92`	`return copy;`
`93`	`93`	`}`
`94`	`94`