Merge pull request #35568 from apple/SIL-Gate-checkForLeaksAfterDestruction-to-asserts-builds

kastiglione · web-flow · commit c36c32027e6b · 2021-01-27T10:30:47.000-08:00
SIL: Gate checkForLeaksAfterDestruction to asserts builds
diff --git a/lib/SIL/IR/SILModule.cpp b/lib/SIL/IR/SILModule.cpp
@@ -167,13 +167,17 @@ void SILModule::checkForLeaks() const {
 }
 
 void SILModule::checkForLeaksAfterDestruction() {
+// Disabled in release (non-assert) builds because this check fails in rare
+// cases in lldb, causing crashes. rdar://70826934
+#ifndef NDEBUG
   int numAllocated = SILInstruction::getNumCreatedInstructions() -
                      SILInstruction::getNumDeletedInstructions();
 
   if (numAllocated != 0) {
     llvm::errs() << "Leaking " << numAllocated << " instructions!\n";
     llvm_unreachable("leaking instructions");
   }
+#endif
 }
 
 std::unique_ptr<SILModule> SILModule::createEmptyModule(

Original file line number	Diff line number	Diff line change
`@@ -167,13 +167,17 @@ void SILModule::checkForLeaks() const {`
`167`	`167`	`}`
`168`	`168`
`169`	`169`	`void SILModule::checkForLeaksAfterDestruction() {`
	`170`	`+// Disabled in release (non-assert) builds because this check fails in rare`
	`171`	`+// cases in lldb, causing crashes. rdar://70826934`
	`172`	`+#ifndef NDEBUG`
`170`	`173`	`int numAllocated = SILInstruction::getNumCreatedInstructions() -`
`171`	`174`	`SILInstruction::getNumDeletedInstructions();`
`172`	`175`
`173`	`176`	`if (numAllocated != 0) {`
`174`	`177`	`llvm::errs() << "Leaking " << numAllocated << " instructions!\n";`
`175`	`178`	`llvm_unreachable("leaking instructions");`
`176`	`179`	`}`
	`180`	`+#endif`
`177`	`181`	`}`
`178`	`182`
`179`	`183`	`std::unique_ptr<SILModule> SILModule::createEmptyModule(`