Remove unnecessary enum case check

Itai Ferber · Itai Ferber · commit c515b53fccd5 · 2017-04-26T11:06:38.000-07:00
diff --git a/lib/AST/Decl.cpp b/lib/AST/Decl.cpp
@@ -2110,9 +2110,9 @@ bool NominalTypeDecl::derivesProtocolConformance(ProtocolDecl *protocol) const {
         return nominal == C.getStringDecl() || nominal == C.getIntDecl();
       }
 
-      // Empty enums are allowed to conform as well.
-      return enumDecl->getAllElements().empty() ||
-             enumDecl->hasOnlyCasesWithoutAssociatedValues();
+      // hasOnlyCasesWithoutAssociatedValues will return true for empty enums;
+      // empty enumas are allowed to conform as well.
+      return enumDecl->hasOnlyCasesWithoutAssociatedValues();
     }
 
     default:

Original file line number	Diff line number	Diff line change
`@@ -2110,9 +2110,9 @@ bool NominalTypeDecl::derivesProtocolConformance(ProtocolDecl *protocol) const {`
`2110`	`2110`	`return nominal == C.getStringDecl() \|\| nominal == C.getIntDecl();`
`2111`	`2111`	`}`
`2112`	`2112`
`2113`		`- // Empty enums are allowed to conform as well.`
`2114`		`- return enumDecl->getAllElements().empty() \|\|`
`2115`		`- enumDecl->hasOnlyCasesWithoutAssociatedValues();`
	`2113`	`+ // hasOnlyCasesWithoutAssociatedValues will return true for empty enums;`
	`2114`	`+ // empty enumas are allowed to conform as well.`
	`2115`	`+ return enumDecl->hasOnlyCasesWithoutAssociatedValues();`
`2116`	`2116`	`}`
`2117`	`2117`
`2118`	`2118`	`default:`