Add and update lifetime_dependence unit tests.

Author: atrick

test/SILGen/addressors.swift

@@ -102,7 +102,7 @@ func test1() -> Int32 {
 // CHECK: [[PTR:%.*]] = apply [[ACCESSOR]]({{%.*}}, [[A]]) : $@convention(method) (Int32, A) -> UnsafePointer<Int32>
 // CHECK: [[T0:%.*]] = struct_extract [[PTR]] : $UnsafePointer<Int32>, #UnsafePointer._rawValue
 // CHECK: [[T1:%.*]] = pointer_to_address [[T0]] : $Builtin.RawPointer to [strict] $*Int32
-// CHECK: [[MD:%.*]] = mark_dependence [[T1]] : $*Int32 on [[A]] : $A
+// CHECK: [[MD:%.*]] = mark_dependence [nonescaping] [[T1]] : $*Int32 on [[A]] : $A
 // CHECK: [[ACCESS:%.*]] = begin_access [read] [unsafe] [[MD]] : $*Int32
 // CHECK: [[T2:%.*]] = load [[ACCESS]] : $*Int32
 // CHECK: return [[T2]] : $Int32

test/SILOptimizer/lifetime_dependence/diagnostic_passes.sil

@@ -1,8 +1,8 @@
-// RUN: %target-sil-opt -test-runner %s \
+// RUN: %target-sil-opt %s \
 // RUN:     -diagnostics -sil-verify-all \
 // RUN:     -enable-experimental-feature LifetimeDependence \
 // RUN:     -enable-experimental-feature Span \
-// RUN:     2>&1 | %FileCheck %s
+// RUN:     | %FileCheck %s
 
 // Test SIL expected from SILGen output. Run all diagnostic passes which includes lifetime dependence handling:
 // -lifetime-dependence-insertion

test/SILOptimizer/lifetime_dependence/lifetime_dependence_scope.swift

@@ -133,8 +133,7 @@ entry(%0 : @owned $C, %1 : @owned $D, %2 : @guaranteed $D, %3 : $*D, %4 : $*D):
 // CHECK-LABEL: dependence_scope: lifetime_dependence_scope with: %trivial_mark
 // CHECK-NEXT: Unknown:   %{{.*}} = integer_literal $Builtin.Int1, 0
 // CHECK-NEXT: Dependent: %{{.*}} = mark_dependence [nonescaping]
-// CHECK-NEXT: begin:     %{{.*}} = integer_literal $Builtin.Int1, 0
-// CHECK-NEXT: ends:{{[ ]+$}}
+// CHECK-NEXT: Caller range
 // CHECK: dependence_scope: lifetime_dependence_scope with: %trivial_mark
 
   %f = ref_element_addr %borrow : $D, #D.object
@@ -166,8 +165,10 @@ entry(%0 : @owned $C, %1 : @owned $D, %2 : @guaranteed $D, %3 : $*D, %4 : $*D):
 
   %inout_arg_mark = mark_dependence [nonescaping] %inguaranteed_arg_mark : $C on %4 : $*D
   specify_test "lifetime_dependence_scope %inout_arg_mark"
+// We do not expect a direct dependence on in inout argument. Treat it as unknown.
+// Instead, mutable variable access should have an access scope.
 // CHECK-LABEL: dependence_scope: lifetime_dependence_scope with: %inout_arg_mark
-// CHECK-NEXT: Caller:     %4 = argument of bb0 : $*D
+// CHECK-NEXT: Unknown:     %4 = argument of bb0 : $*D
 // CHECK-NEXT: Dependent:  %{{.*}} = mark_dependence [nonescaping] %{{.*}} : $C on %4 : $*D
 // CHECK: dependence_scope: lifetime_dependence_scope with: %inout_arg_mark
 
@@ -180,37 +181,6 @@ entry(%0 : @owned $C, %1 : @owned $D, %2 : @guaranteed $D, %3 : $*D, %4 : $*D):
   return %99 : $()
 }
 
-sil [ossa] @dependence_root : $@convention(thin) (@owned D, @owned C) -> () {
-entry(%0 : @owned $D, %1 : @owned $C):
-  %copy = copy_value %0 : $D
-  %move = move_value %copy : $D
-  %borrow = begin_borrow %move : $D
-  %d2c = upcast %borrow : $D to $C
-  %pair = struct $PairC(%d2c : $C, %d2c : $C)
-  %mark_pair = mark_dependence [nonescaping] %1 : $C on %pair : $PairC
-  specify_test "lifetime_dependence_root %mark_pair"
-// CHECK-LABEL: dependence_root: lifetime_dependence_root with: %mark_pair
-// CHECK-NEXT: Scope: Owned: %0 = argument of bb0 : $D
-// CHECK-NEXT: dependence_root: lifetime_dependence_root with: %mark_pair
-
-  %f = ref_element_addr %borrow : $D, #D.object
-  %access = begin_access [read] [static] %f : $*C
-  %load = load [copy] %access : $*C
-  specify_test "lifetime_dependence_root %load"
-// CHECK-LABEL: dependence_root: lifetime_dependence_root with: %load
-// CHECK-NEXT: Scope: Unknown:   %{{.*}} = ref_element_addr %{{.*}} : $D, #D.object
-// CHECK-NEXT: dependence_root: lifetime_dependence_root with: %load
-
-  destroy_value %load : $C
-  end_access %access : $*C
-  destroy_value %mark_pair : $C
-  end_borrow %borrow : $D
-  destroy_value %move : $D
-  destroy_value %0 : $D
-  %99 = tuple()
-  return %99 : $()
-}
-
 // CHECK-LABEL: dependence_access: lifetime_dependence_use with: %0
 // CHECK: LifetimeDependence uses of: %0 = argument of bb0 : $*NE
 // CHECK-NEXT: Leaf use: operand #0 of   end_access %{{.*}} : $*NE

test/SILOptimizer/lifetime_dependence/lifetime_dependence_util.sil

@@ -91,11 +91,11 @@ sil @pointeeAddressor : $@convention(method) <τ_0_0 where τ_0_0 : ~Copyable> (
 // CHECK: bb0(%0 : $UnsafePointer<Int64>):
 // CHECK:   [[ACCESS:%.*]] = begin_access [read] [unknown]
 // CHECK:   [[LD:%.*]] = load [trivial] [[ACCESS]]
+// CHECK:   end_access [[ACCESS]]
 // CHECK:   [[ADR:%.*]] = pointer_to_address %{{.*}} to [strict] $*Int64
 // CHECK:   [[MD:%.*]] = mark_dependence [unresolved] [[ADR]] on [[LD]]
 // CHECK:   [[ACCESS2:%.*]] = begin_access [read] [unsafe] [[MD]]
 // CHECK:   end_access [[ACCESS2]]
-// CHECK:   end_access [[ACCESS]]
 // CHECK-LABEL: } // end sil function 'testTrivialAccess'
 sil hidden [ossa] @testTrivialAccess : $@convention(thin) (UnsafePointer<Int64>) -> () {
 bb0(%0 : $UnsafePointer<Int64>):