SR-11889: Fixed code review issues

1. Removed two braces {{ usage of Located initialization
2. Wrapped documentation into 80 characters

Author: kitaisreal

include/swift/Basic/Located.h

@@ -10,7 +10,8 @@
 //
 //===----------------------------------------------------------------------===//
 //
-// Provides a currency data type Located<T> that should be used instead of std::pair<T, SourceLoc>.
+// Provides a currency data type Located<T> that should be used instead
+// of std::pair<T, SourceLoc>.
 //
 //===----------------------------------------------------------------------===//
 
@@ -22,11 +23,12 @@
 namespace swift {
 
 /// A currency type for keeping track of items which were found in the source code.
-///
-/// Several parts of the compiler need to keep track of a `SourceLoc` corresponding to an item, in case
-/// they need to report some diagnostics later. For example, the ClangImporter needs to keep track
-/// of where imports were originally written. Located makes it easy to do so while making the code
-/// more readable, compared to using `std::pair`.
+/// Several parts of the compiler need to keep track of a `SourceLoc` corresponding
+/// to an item, in case they need to report some diagnostics later. For example,
+/// the ClangImporter needs to keep track of where imports were originally written.
+/// Located makes it easy to do so while making the code more readable, compared to
+/// using `std::pair`.
+
 template<typename T>
 struct Located {
 

lib/AST/ASTContext.cpp

@@ -1778,7 +1778,7 @@ ModuleDecl *ASTContext::getStdlibModule(bool loadIfAbsent) {
   if (loadIfAbsent) {
     auto mutableThis = const_cast<ASTContext*>(this);
     TheStdlibModule =
-      mutableThis->getModule({{ StdlibModuleName, SourceLoc() }});
+      mutableThis->getModule({ Located<Identifier>(StdlibModuleName, SourceLoc()) });
   } else {
     TheStdlibModule = getLoadedModule(StdlibModuleName);
   }

lib/Frontend/Frontend.cpp

@@ -778,7 +778,7 @@ ModuleDecl *CompilerInstance::importUnderlyingModule() {
   ModuleDecl *objCModuleUnderlyingMixedFramework =
       static_cast<ClangImporter *>(Context->getClangModuleLoader())
           ->loadModule(SourceLoc(),
-                       {{MainModule->getName(), SourceLoc()}});
+                       { Located<Identifier>(MainModule->getName(), SourceLoc()) });
   if (objCModuleUnderlyingMixedFramework)
     return objCModuleUnderlyingMixedFramework;
   Diagnostics.diagnose(SourceLoc(), diag::error_underlying_module_not_found,
@@ -808,7 +808,7 @@ void CompilerInstance::getImplicitlyImportedModules(
     if (Lexer::isIdentifier(ImplicitImportModuleName)) {
       auto moduleID = Context->getIdentifier(ImplicitImportModuleName);
       ModuleDecl *importModule =
-        Context->getModule({{moduleID, SourceLoc()}});
+        Context->getModule({ Located<Identifier>(moduleID, SourceLoc()) });
       if (importModule) {
         importModules.push_back(importModule);
       } else {

lib/FrontendTool/ImportedModules.cpp

@@ -98,7 +98,7 @@ bool swift::emitImportedModules(ASTContext &Context, ModuleDecl *mainModule,
   }
 
   if (opts.ImportUnderlyingModule) {
-    auto underlyingModule = clangImporter->loadModule(SourceLoc(), {{ mainModule->getName(), SourceLoc() }});
+    auto underlyingModule = clangImporter->loadModule(SourceLoc(), { Located<Identifier>(mainModule->getName(), SourceLoc()) });
     if (!underlyingModule) {
       Context.Diags.diagnose(SourceLoc(),
                              diag::error_underlying_module_not_found,

tools/SourceKit/lib/SwiftLang/SwiftDocSupport.cpp

@@ -52,7 +52,7 @@ static ModuleDecl *getModuleByFullName(ASTContext &Ctx, StringRef ModuleName) {
 }
 
 static ModuleDecl *getModuleByFullName(ASTContext &Ctx, Identifier ModuleName) {
-  return Ctx.getModule({{ModuleName, SourceLoc()}});
+  return Ctx.getModule({ Located<Identifier>(ModuleName, SourceLoc()) });
 }
 
 namespace {

tools/SourceKit/lib/SwiftLang/SwiftEditorInterfaceGen.cpp

@@ -103,7 +103,7 @@ static ModuleDecl *getModuleByFullName(ASTContext &Ctx, StringRef ModuleName) {
 }
 
 static ModuleDecl *getModuleByFullName(ASTContext &Ctx, Identifier ModuleName) {
-  return Ctx.getModule({{ModuleName, SourceLoc()}});
+  return Ctx.getModule({ Located<Identifier>(ModuleName, SourceLoc()) });
 }
 
 namespace {

tools/swift-ide-test/swift-ide-test.cpp

@@ -1600,7 +1600,7 @@ static ModuleDecl *getModuleByFullName(ASTContext &Context, StringRef ModuleName
 }
 
 static ModuleDecl *getModuleByFullName(ASTContext &Context, Identifier ModuleName) {
-  ModuleDecl *Result = Context.getModule({{ModuleName,SourceLoc()}});
+  ModuleDecl *Result = Context.getModule({ Located<Identifier>(ModuleName,SourceLoc()) });
   if (!Result || Result->failedToLoad())
     return nullptr;
   return Result;