[AST] Teach NormalProtocolConformance to resolve known, synthesized witnesses.

There are a number of type witnesses that are introduced by the Clang
importer. Immediately resolve those witnesses *without* going through
the type checker, because there are cases (i.e., deserialized SIL)
where the conformance is created but there is no type checker around.

Fixes rdar://problem/30364905, rdar://problem/31053701,
rdar://problem/31565413 / SR-4565.

Author: DougGregor

lib/AST/ProtocolConformance.cpp

@@ -398,6 +398,91 @@ bool NormalProtocolConformance::hasTypeWitness(AssociatedTypeDecl *assocType,
   return false;
 }
 
+/// Directly resolve type witnesses that are known to the compiler because they
+/// were synthesized by the compiler.
+///
+/// FIXME: This is a hack to work around the fact that we don't have a
+/// TypeChecker when we need one.
+///
+/// \returns true if we resolved the type witness.
+static bool resolveKnownTypeWitness(NormalProtocolConformance *conformance,
+                                    AssociatedTypeDecl *assocType) {
+  auto nominal = conformance->getType()->getAnyNominal();
+  if (!nominal) return false;
+
+  if (!nominal->hasClangNode()) return false;
+
+  auto proto = conformance->getProtocol();
+  auto knownKind = proto->getKnownProtocolKind();
+  if (!knownKind) return false;
+
+  auto &ctx = nominal->getASTContext();
+
+  // Local function to handle resolution via lookup directly into the nominal
+  // type.
+  auto resolveViaLookup = [&] {
+    for (auto member : nominal->lookupDirect(assocType->getFullName())) {
+      auto memberType = dyn_cast<TypeDecl>(member);
+      if (!memberType) continue;
+      if (memberType->getDeclContext() != nominal) continue;
+
+      conformance->setTypeWitness(assocType,
+                                  nominal->mapTypeIntoContext(
+                                    memberType->getDeclaredInterfaceType()),
+                                  memberType);
+      return true;
+    }
+
+    return false;
+  };
+
+  // RawRepresentable.RawValue.
+  if (*knownKind == KnownProtocolKind::RawRepresentable) {
+    assert(assocType->getName() == ctx.Id_RawValue);
+    if (auto enumDecl = dyn_cast<EnumDecl>(nominal)) {
+      // First, try to resolve via lookup, so we get the declaration.
+      if (resolveViaLookup()) return true;
+
+      // Otherwise, use the raw type.
+      if (enumDecl->hasRawType()) {
+        conformance->setTypeWitness(assocType, enumDecl->getRawType(), nullptr);
+        return true;
+      }
+
+      return false;
+    }
+
+    // All other cases resolve via lookup.
+    return resolveViaLookup();
+  }
+
+  // OptionSet.Element.
+  if (*knownKind == KnownProtocolKind::OptionSet) {
+    assert(assocType->getName() == ctx.Id_Element);
+    return resolveViaLookup();
+  }
+
+  // _ObjectiveCBridgeable._ObjectiveCType
+  if (*knownKind == KnownProtocolKind::ObjectiveCBridgeable) {
+    assert(assocType->getName() == ctx.Id_ObjectiveCType);
+    return resolveViaLookup();
+  }
+
+  // _BridgedStoredNSError.Code
+  if (*knownKind == KnownProtocolKind::BridgedStoredNSError) {
+    assert(assocType->getName() == ctx.Id_Code);
+    return resolveViaLookup();
+  }
+
+  // ErrorCodeProtocol._ErrorType.
+  if (*knownKind == KnownProtocolKind::ErrorCodeProtocol) {
+    assert(assocType->getName() == ctx.Id_ErrorType);
+    return resolveViaLookup();
+  }
+
+  return false;
+}
+
 std::pair<Type, TypeDecl *>
 NormalProtocolConformance::getTypeWitnessAndDecl(AssociatedTypeDecl *assocType,
                                                  LazyResolver *resolver) const {
@@ -407,8 +492,11 @@ NormalProtocolConformance::getTypeWitnessAndDecl(AssociatedTypeDecl *assocType,
   auto known = TypeWitnesses.find(assocType);
   if (known == TypeWitnesses.end()) {
     PrettyStackTraceRequirement trace("resolving", this, assocType);
-    assert(resolver && "Unable to resolve type witness");
-    resolver->resolveTypeWitness(this, assocType);
+    if (!resolveKnownTypeWitness(const_cast<NormalProtocolConformance *>(this),
+                                 assocType)) {
+      assert(resolver && "Unable to resolve type witness");
+      resolver->resolveTypeWitness(this, assocType);
+    }
     known = TypeWitnesses.find(assocType);
     assert(known != TypeWitnesses.end() && "Didn't resolve witness?");
   }

test/Serialization/Inputs/use_imported_enums.swift

@@ -0,0 +1,9 @@
+import Foundation
+
+@inline(__always) @_transparent public func compareToSelf<T: Equatable>(_ t: T) -> Bool {
+  return t == t
+}
+
+@inline(__always) @_transparent public func compareImportedEnumToSelf(_ e: NSRuncingMode) -> Bool {
+  return compareToSelf(e)
+}

test/Serialization/sil-imported-enums.swift

@@ -0,0 +1,22 @@
+// RUN: rm -rf %t
+// RUN: mkdir -p %t
+
+// FIXME: BEGIN -enable-source-import hackaround
+// RUN: %target-swift-frontend(mock-sdk: %clang-importer-sdk) -emit-module -o %t %clang-importer-sdk-path/swift-modules/CoreGraphics.swift
+// RUN: %target-swift-frontend(mock-sdk: %clang-importer-sdk) -emit-module -o %t %clang-importer-sdk-path/swift-modules/Foundation.swift
+// FIXME: END -enable-source-import hackaround
+
+// RUN: %target-swift-frontend(mock-sdk: %clang-importer-sdk-nosource -I %t) -emit-module -o %t -parse-as-library %S/Inputs/use_imported_enums.swift -module-name UsesImportedEnums
+// RUN: %target-swift-frontend(mock-sdk: %clang-importer-sdk-nosource -I %t) -emit-sil %s | %FileCheck %s
+
+// REQUIRES: objc_interop
+
+import Foundation
+import UsesImportedEnums
+
+// CHECK-LABEL: sil hidden @_T04main4testSbSC13NSRuncingModeO1e_tF
+func test(e: NSRuncingMode) -> Bool {
+  // CHECK-NOT: return
+  // CHECK: _T0s2eeoiSbx_xts16RawRepresentableRzs9Equatable0B5ValueRpzlF
+  return compareImportedEnumToSelf(e)
+}