[Distributed] Link missing feature FIXME's with radar number

Author: ktoso

lib/Sema/CodeSynthesisDistributedActor.cpp

@@ -793,7 +793,6 @@ FuncDecl *GetDistributedThunkRequest::evaluate(
     return nullptr;
 
   auto &C = distributedTarget->getASTContext();
-  auto DC = distributedTarget->getDeclContext();
 
   if (!getConcreteReplacementForProtocolActorSystemType(distributedTarget)) {
     // Don't synthesize thunks, unless there is a *concrete* ActorSystem.
@@ -817,9 +816,6 @@ FuncDecl *GetDistributedThunkRequest::evaluate(
     if (!C.getLoadedModule(C.Id_Distributed))
       return nullptr;
 
-    auto nominal = DC->getSelfNominalTypeDecl(); // NOTE: Always from DC
-    assert(nominal);
-
     // --- Prepare the "distributed thunk" which does the "maybe remote" dance:
     return createDistributedThunkFunction(func);
   }

lib/Sema/TypeCheckDeclPrimary.cpp

@@ -2877,6 +2877,7 @@ class DeclChecker : public DeclVisitor<DeclChecker> {
     }
 
     TypeChecker::checkDeclAttributes(FD);
+    TypeChecker::checkDistributedFunc(FD);
 
     if (!checkOverrides(FD)) {
       // If a method has an 'override' keyword but does not
@@ -2964,9 +2965,6 @@ class DeclChecker : public DeclVisitor<DeclChecker> {
       }
     }
 
-    fprintf(stderr, "[%s:%d] (%s) CHECK DIST ON...\n", __FILE__, __LINE__, __FUNCTION__);
-    TypeChecker::checkDistributedFunc(FD);
-
     // If the function is exported to C, it must be representable in (Obj-)C.
     // FIXME: This needs to be moved to its own request if we want to
     // productize @_cdecl.

lib/Sema/TypeCheckDistributed.cpp

@@ -484,7 +484,6 @@ bool swift::checkDistributedFunction(AbstractFunctionDecl *func) {
 bool CheckDistributedFunctionRequest::evaluate(
     Evaluator &evaluator, AbstractFunctionDecl *func) const {
   assert(func->isDistributed());
-  fprintf(stderr, "[%s:%d] (%s) check function: %s\n", __FILE__, __LINE__, __FUNCTION__, func->getNameStr().str().c_str());
 
   auto &C = func->getASTContext();
   auto DC = func->getDeclContext();

test/Distributed/Runtime/distributed_actor_func_calls_remoteCall_through_generic.swift

@@ -1,7 +1,7 @@
 // RUN: %empty-directory(%t)
 // RUN: %target-swift-frontend-emit-module -emit-module-path %t/FakeDistributedActorSystems.swiftmodule -module-name FakeDistributedActorSystems -disable-availability-checking %S/../Inputs/FakeDistributedActorSystems.swift
 // RUN: %target-build-swift -module-name main -Xfrontend -disable-availability-checking -j2 -parse-as-library -I %t %s %S/../Inputs/FakeDistributedActorSystems.swift -o %t/a.out
-// RUN: %target-run %t/a.out | %FileCheck %s --color --dump-input=always
+// RUN: %target-run %t/a.out | %FileCheck %s --color
 
 // REQUIRES: executable_test
 // REQUIRES: concurrency

test/Distributed/distributed_actor_inference.swift

@@ -42,12 +42,12 @@ protocol DP {
 }
 
 protocol DPOK: DistributedActor {
-  distributed func hello() // FIXME(distributed): not possible today...
+  distributed func hello() // FIXME(distributed): rdar://95949498 currently we are limited to explicitly 'async throws' protocol requirements that are distributed funcs
   // expected-error@-1{{'distributed' protocol requirement 'hello()' must currently be declared explicitly 'async throws'}}
 }
 
 protocol DPOK2: DPOK {
-  distributed func again() // FIXME(distributed): not possible today...
+  distributed func again() // FIXME(distributed): rdar://95949498 currently we are limited to explicitly 'async throws' protocol requirements that are distributed funcs
   // expected-error@-1{{'distributed' protocol requirement 'again()' must currently be declared explicitly 'async throws'}}
 }
 

test/Distributed/distributed_actor_protocol_isolation.swift

@@ -37,17 +37,17 @@ protocol MixedProtoDistributedActor: DistributedActor {
   func localThrows() throws
   func localAsyncThrows() async throws
 
-//  distributed func dist() // FIXME(distributed): not possible today...
-//  distributed func distAsync() async // FIXME(distributed): not possible today...
+//  distributed func dist() // FIXME(distributed): rdar://95949498 currently we are limited to explicitly 'async throws' protocol requirements that are distributed funcs
+//  distributed func distAsync() async // FIXME(distributed): rdar://95949498 currently we are limited to explicitly 'async throws' protocol requirements that are distributed funcs
   distributed func distAsyncThrows() async throws
 }
 
 protocol DistProtoDistributedActor: DistributedActor {
-  distributed func dist() // FIXME(distributed): not possible today...
+  distributed func dist() // FIXME(distributed): rdar://95949498 currently we are limited to explicitly 'async throws' protocol requirements that are distributed funcs
   // expected-error@-1{{'distributed' protocol requirement 'dist()' must currently be declared explicitly 'async throws'}}
-  distributed func distAsync() async // FIXME(distributed): not possible today...
+  distributed func distAsync() async // FIXME(distributed): rdar://95949498 currently we are limited to explicitly 'async throws' protocol requirements that are distributed funcs
   // expected-error@-1{{'distributed' protocol requirement 'distAsync()' must currently be declared explicitly 'async throws'}}
-  distributed func distThrows() throws // FIXME(distributed): not possible today...
+  distributed func distThrows() throws // FIXME(distributed): rdar://95949498 currently we are limited to explicitly 'async throws' protocol requirements that are distributed funcs
   // expected-error@-1{{'distributed' protocol requirement 'distThrows()' must currently be declared explicitly 'async throws'}}
   distributed func distAsyncThrows() async throws
 }

test/Distributed/distributed_protocol_isolation.swift

@@ -25,14 +25,14 @@ protocol DistProtocol: DistributedActor {
   // expected-note@-3{{distributed actor-isolated instance method 'local()' declared here}}
   // expected-note@-4{{distributed actor-isolated instance method 'local()' declared here}}
 
-  distributed func dist() -> String // FIXME(distributed): not possible today...
+  distributed func dist() -> String // FIXME(distributed): rdar://95949498 currently we are limited to explicitly 'async throws' protocol requirements that are distributed funcs
   // expected-error@-1{{'distributed' protocol requirement 'dist()' must currently be declared explicitly 'async throws'}}
-  distributed func dist(string: String) -> String // FIXME(distributed): not possible today...
+  distributed func dist(string: String) -> String // FIXME(distributed): rdar://95949498 currently we are limited to explicitly 'async throws' protocol requirements that are distributed funcs
   // expected-error@-1{{'distributed' protocol requirement 'dist(string:)' must currently be declared explicitly 'async throws'}}
 
-  distributed func distAsync() async -> String // FIXME(distributed): not possible today...
+  distributed func distAsync() async -> String // FIXME(distributed): rdar://95949498 currently we are limited to explicitly 'async throws' protocol requirements that are distributed funcs
   // expected-error@-1{{'distributed' protocol requirement 'distAsync()' must currently be declared explicitly 'async throws'}}
-  distributed func distThrows() throws -> String // FIXME(distributed): not possible today...
+  distributed func distThrows() throws -> String // FIXME(distributed): rdar://95949498 currently we are limited to explicitly 'async throws' protocol requirements that are distributed funcs
   // expected-error@-1{{'distributed' protocol requirement 'distThrows()' must currently be declared explicitly 'async throws'}}
   distributed func distAsyncThrows() async throws -> String
 }
@@ -257,7 +257,7 @@ func test_watchingDA_any(da: any TerminationWatchingDA) async throws {
 // MARK: Error cases
 
 protocol ErrorCases: DistributedActor {
-  distributed func unexpectedAsyncThrows() -> String // FIXME(distributed): not possible today...
+  distributed func unexpectedAsyncThrows() -> String // FIXME(distributed): rdar://95949498 currently we are limited to explicitly 'async throws' protocol requirements that are distributed funcs
   // expected-error@-1{{'distributed' protocol requirement 'unexpectedAsyncThrows()' must currently be declared explicitly 'async throws'}}
   // expected-note@-2{{protocol requires function 'unexpectedAsyncThrows()' with type '() -> String'; do you want to add a stub?}}
 }

test/Distributed/distributed_protocols_distributed_func_serialization_requirements.swift

@@ -10,7 +10,7 @@ import FakeDistributedActorSystems
 struct NotCodable {}
 
 protocol NoSerializationRequirementYet: DistributedActor {
-  distributed func test() -> NotCodable // FIXME(distributed): not possible today...
+  distributed func test() -> NotCodable // FIXME(distributed): rdar://95949498 currently we are limited to explicitly 'async throws' protocol requirements that are distributed funcs
   // expected-error@-1{{'distributed' protocol requirement 'test()' must currently be declared explicitly 'async throws'}}
 
   // OK, no serialization requirement yet

test/decl/protocol/special/DistributedActor.swift

@@ -64,7 +64,7 @@ distributed actor D4 {
 }
 
 protocol P1: DistributedActor {
-  distributed func dist() -> String // FIXME(distributed): not possible today...
+  distributed func dist() -> String // FIXME(distributed): rdar://95949498 currently we are limited to explicitly 'async throws' protocol requirements that are distributed funcs
   // expected-error@-1{{'distributed' protocol requirement 'dist()' must currently be declared explicitly 'async throws'}}
   // expected-note@-2{{'dist()' declared here}}
 }