SerializeLoc: remove NameLoc entry in the serialized format

Having both Loc and NameLoc fields seems to be redundant.

Author: nkcsgexi

include/swift/AST/RawComment.h

@@ -87,7 +87,6 @@ struct LineColumn {
 struct BasicDeclLocs {
   StringRef SourceFilePath;
   LineColumn Loc;
-  LineColumn NameLoc;
   LineColumn StartLoc;
   LineColumn EndLoc;
 };

lib/Serialization/ModuleFile.cpp

@@ -2387,8 +2387,8 @@ Optional<BasicDeclLocs> ModuleFile::getBasicDeclLocsForDecl(const Decl *D) const
   auto UsrId = *It;
   uint32_t NumSize = 4;
   // Size of BasicDeclLocs in the buffer.
-  // FilePathOffset + 4 * LineColumn
-  uint32_t LineColumnCount = 4;
+  // FilePathOffset + LocNum * LineColumn
+  uint32_t LineColumnCount = 3;
   uint32_t RecordSize = NumSize + NumSize * 2 * LineColumnCount;
   uint32_t RecordOffset = RecordSize * UsrId;
   assert(RecordOffset < BasicDeclLocsData.size());
@@ -2408,7 +2408,6 @@ Optional<BasicDeclLocs> ModuleFile::getBasicDeclLocsForDecl(const Decl *D) const
 Result.X.Line = ReadNext();                                                                       \
 Result.X.Column = ReadNext();
   READ_FIELD(Loc)
-  READ_FIELD(NameLoc)
   READ_FIELD(StartLoc)
   READ_FIELD(EndLoc)
 #undef READ_FIELD

lib/Serialization/SerializeDoc.cpp

@@ -513,7 +513,6 @@ namespace {
 struct DeclLocationsTableData {
   uint32_t SourceFileOffset;
   LineColumn Loc;
-  LineColumn NameLoc;
   LineColumn StartLoc;
   LineColumn EndLoc;
 };
@@ -621,7 +620,6 @@ struct BasicDeclLocsTableWriter : public ASTWalker {
 writer.write<uint32_t>(data.X.Line);                                                              \
 writer.write<uint32_t>(data.X.Column);
     WRITE_LINE_COLUMN(Loc)
-    WRITE_LINE_COLUMN(NameLoc);
     WRITE_LINE_COLUMN(StartLoc);
     WRITE_LINE_COLUMN(EndLoc);
 #undef WRITE_LINE_COLUMN
@@ -657,13 +655,6 @@ writer.write<uint32_t>(data.X.Column);
     llvm::sys::fs::make_absolute(SourceFilePath);
     Result.SourceFileOffset = FWriter.getTextOffset(SourceFilePath);
     Result.Loc = getLineColumn(SM, D->getLoc());
-    if (auto *VD = dyn_cast<ValueDecl>(D)) {
-      Result.NameLoc = getLineColumn(SM, VD->getNameLoc());
-    } else if(auto *OD = dyn_cast<OperatorDecl>(D)) {
-      Result.NameLoc = getLineColumn(SM, OD->getNameLoc());
-    } else if(auto *PD = dyn_cast<PrecedenceGroupDecl>(D)) {
-      Result.NameLoc = getLineColumn(SM, PD->getNameLoc());
-    }
     Result.StartLoc = getLineColumn(SM, D->getStartLoc());
     Result.EndLoc = getLineColumn(SM, D->getEndLoc());
     return Result;
@@ -685,7 +676,6 @@ writer.write<uint32_t>(data.X.Column);
 Result.X.Line = Locs->X.Line;                                                                     \
 Result.X.Column = Locs->X.Column;
       COPY_LINE_COLUMN(Loc)
-      COPY_LINE_COLUMN(NameLoc)
       COPY_LINE_COLUMN(StartLoc)
       COPY_LINE_COLUMN(EndLoc)
 #undef COPY_LINE_COLUMN