Skip to content

Commit c9abb0b

Browse files
committed
[Backtracing] Improve warning message about thread suspension failure.
In the event that the backtracer fails to suspend a thread, it emits a warning message. Unfortunately the exact meaning of this message isn't obvious and it doesn't make clear that it's a secondary problem (that is, you've already crashed at this point). Update the message to make things clearer. rdar://116593541
1 parent 338d426 commit c9abb0b

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

stdlib/public/runtime/CrashHandlerLinux.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -531,9 +531,10 @@ suspend_other_threads(struct thread *self)
531531
tgkill(our_pid, tid, sig_to_use);
532532
++pending;
533533
} else {
534-
warn("swift-runtime: unable to suspend thread ");
534+
warn("swift-runtime: failed to suspend thread ");
535535
warn(dp->d_name);
536-
warn("\n");
536+
warn(" while processing a crash; backtraces will be missing "
537+
"information\n");
537538
}
538539
}
539540
}

0 commit comments

Comments
 (0)