[stdlib] Let’s try leaving Set/Dictionary storage non-fixed as an experiment

lorentey · lorentey · commit ca09281b3418 · 2018-11-12T21:01:23.000Z
The current ivars are all defined in the parent class, so (provided my mental model of how this works is correct) this may make some actual sense.
diff --git a/stdlib/public/core/DictionaryStorage.swift b/stdlib/public/core/DictionaryStorage.swift
@@ -192,7 +192,6 @@ extension _RawDictionaryStorage {
   }
 }
 
-@_fixed_layout // FIXME(sil-serialize-all)
 @usableFromInline
 final internal class _DictionaryStorage<Key: Hashable, Value>
   : _RawDictionaryStorage, _NSDictionaryCore {
diff --git a/stdlib/public/core/SetStorage.swift b/stdlib/public/core/SetStorage.swift
@@ -175,7 +175,6 @@ extension _EmptySetSingleton: _NSSetCore {
 #endif
 }
 
-@_fixed_layout // FIXME(sil-serialize-all)
 @usableFromInline
 final internal class _SetStorage<Element: Hashable>
   : _RawSetStorage, _NSSetCore {

Original file line number	Diff line number	Diff line change
`@@ -192,7 +192,6 @@ extension _RawDictionaryStorage {`
`192`	`192`	`}`
`193`	`193`	`}`
`194`	`194`
`195`		`-@_fixed_layout // FIXME(sil-serialize-all)`
`196`	`195`	`@usableFromInline`
`197`	`196`	`final internal class _DictionaryStorage<Key: Hashable, Value>`
`198`	`197`	`: _RawDictionaryStorage, _NSDictionaryCore {`
Original file line number	Diff line number	Diff line change
`@@ -175,7 +175,6 @@ extension _EmptySetSingleton: _NSSetCore {`
`175`	`175`	`#endif`
`176`	`176`	`}`
`177`	`177`
`178`		`-@_fixed_layout // FIXME(sil-serialize-all)`
`179`	`178`	`@usableFromInline`
`180`	`179`	`final internal class _SetStorage<Element: Hashable>`
`181`	`180`	`: _RawSetStorage, _NSSetCore {`