Skip to content

Commit cb25720

Browse files
kateinoigakukunCatfish-Man
authored andcommitted
[wasm] Remove workaround for wasi-libc's check-symbols target
Our LLVM has been already updated to 19, so we no longer need to workaround the `__FPCLASS_XXX` macro issue in wasi-libc's check-symbols target.
1 parent 724f979 commit cb25720

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

utils/swift_build_support/swift_build_support/products/wasisysroot.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -58,20 +58,11 @@ def _build(self, host_target, thread_model='single', target_triple='wasm32-wasi'
5858

5959
sysroot_build_dir = WASILibc.sysroot_build_path(
6060
build_root, host_target, target_triple)
61-
# FIXME: Manually create an empty dir that is usually created during
62-
# check-symbols. The directory is required during sysroot installation step.
63-
os.makedirs(os.path.join(sysroot_build_dir, "share"), exist_ok=True)
6461

6562
sysroot_install_path = WASILibc.sysroot_install_path(build_root, target_triple)
6663
shell.call([
6764
'make', 'install',
6865
'-j', str(build_jobs),
69-
# FIXME: wasi-libc's pre-defined macro list does not expect
70-
# `__FPCLASS_XXX`, which is introduced by the LLVM 17, yet.
71-
# So skip the symbol check step by treating the phony target
72-
# as very old file.
73-
# https://github.com/llvm/llvm-project/commit/7dd387d2971d7759cadfffeb2082439f6c7ddd49
74-
'--old-file=check-symbols',
7566
'-C', self.source_dir,
7667
'OBJDIR=' + os.path.join(self.build_dir, 'obj-' + thread_model),
7768
'SYSROOT=' + sysroot_build_dir,

0 commit comments

Comments
 (0)