---

yaml
---
r: 339679
b: refs/heads/rxwei-patch-1
c: 9d22cbb
h: refs/heads/master
i:
  339677: 750e79b
  339675: d5250b5
  339671: b1a9e85
  339663: c07a84f
  339647: c79b73f

Author: drodriguez

[refs]

@@ -1015,7 +1015,7 @@ refs/tags/swift-DEVELOPMENT-SNAPSHOT-2018-08-18-a: b10b1fce14385faa6d44f6b933e95
 refs/heads/rdar-43033749-fix-batch-mode-no-diags-swift-5.0-branch: a14e64eaad30de89f0f5f0b2a782eed7ecdcb255
 refs/heads/revert-19006-error-bridging-integer-type: 8a9065a3696535305ea53fe9b71f91cbe6702019
 refs/heads/revert-19050-revert-19006-error-bridging-integer-type: ecf752d54b05dd0a20f510f0bfa54a3fec3bcaca
-refs/heads/rxwei-patch-1: 69776aac3578a3e3102bd8231c917d7d634c99fb
+refs/heads/rxwei-patch-1: 9d22cbb13ec1ee87384010ff258b9977079914cd
 refs/heads/shahmishal-patch-1: e58ec0f7488258d42bef51bc3e6d7b3dc74d7b2a
 refs/heads/typelist-existential: 4046359efd541fb5c72d69a92eefc0a784df8f5e
 refs/tags/swift-4.2-DEVELOPMENT-SNAPSHOT-2018-08-20-a: 4319ba09e4fb8650ee86061075c74a016b6baab9

branches/rxwei-patch-1/stdlib/private/SwiftPrivateLibcExtras/Subprocess.swift

@@ -217,10 +217,6 @@ public func spawnChild(_ args: [String])
   if pid == 0 {
     // pid of 0 means we are now in the child process.
     // Capture the output before executing the program.
-    close(childStdout.readFD)
-    close(childStdin.writeFD)
-    close(childStderr.readFD)
-    close(childToParentPipe.readFD)
     dup2(childStdout.writeFD, STDOUT_FILENO)
     dup2(childStdin.readFD, STDIN_FILENO)
     dup2(childStderr.writeFD, STDERR_FILENO)
@@ -265,41 +261,6 @@ public func spawnChild(_ args: [String])
 
     // Close the pipe when we're done writing the error.
     close(childToParentPipe.writeFD)
-  } else {
-    close(childToParentPipe.writeFD)
-
-    // Figure out if the child’s call to execve was successful or not.
-    var readfds = _stdlib_fd_set()
-    readfds.set(childToParentPipe.readFD)
-    var writefds = _stdlib_fd_set()
-    var errorfds = _stdlib_fd_set()
-    errorfds.set(childToParentPipe.readFD)
-
-    var ret: CInt
-    repeat {
-      ret = _stdlib_select(&readfds, &writefds, &errorfds, nil)
-    } while ret == -1 && errno == EINTR
-    if ret <= 0 {
-      fatalError("select() returned an error: \(errno)")
-    }
-
-    if readfds.isset(childToParentPipe.readFD) || errorfds.isset(childToParentPipe.readFD) {
-      var childErrno: CInt = 0
-      let readResult: ssize_t = withUnsafeMutablePointer(to: &childErrno) {
-        return read(childToParentPipe.readFD, $0, MemoryLayout.size(ofValue: $0.pointee))
-      }
-      if readResult == 0 {
-        // We read an EOF indicating that the child's call to execve was successful.
-      } else if readResult < 0 {
-        fatalError("read() returned error: \(errno)")
-      } else {
-        // We read an error from the child.
-        print(String(cString: strerror(childErrno)))
-        preconditionFailure("execve() failed")
-      }
-    }
-
-    close(childToParentPipe.readFD)
   }
 #else
   var fileActions = _make_posix_spawn_file_actions_t()

branches/rxwei-patch-1/test/Interpreter/mandatory_inlining.swift

@@ -1,5 +1,7 @@
 // RUN: %target-run-simple-swift
 
+// REQUIRES: executable_test
+
 func test(reportError: ((String) -> (Void))? = nil) {
   let reportError = reportError ?? { error in
     print(error)

branches/rxwei-patch-1/test/Parse/source_locs.swift

@@ -5,4 +5,4 @@ func string_interpolation() {
 }
 
 // RUN: %target-swift-frontend -dump-ast %s | %FileCheck %s
-// CHECK: (interpolated_string_literal_expr {{.*}} trailing_quote_loc=SOURCE_DIR{{/|\\}}test{{/|\\}}Parse{{/|\\}}source_locs.swift:4:12 {{.*}}
+// CHECK: (interpolated_string_literal_expr {{.*}} trailing_quote_loc=SOURCE_DIR/test/Parse/source_locs.swift:4:12 {{.*}}