Merge pull request #19497 from lorentey/dictionary-values-accessor

lorentey · web-flow · commit cc3db35f76ae · 2018-09-24T21:46:33.000+01:00
[stdlib] Dictionary.values: Replace setter with _modify
diff --git a/stdlib/public/core/Dictionary.swift b/stdlib/public/core/Dictionary.swift
@@ -1289,8 +1289,11 @@ extension Dictionary {
     get {
       return Values(_dictionary: self)
     }
-    set {
-      self._variant = newValue._variant
+    _modify {
+      var values = Values(_dictionary: self)
+      _variant = .native(_NativeDictionary())
+      yield &values
+      self._variant = values._variant
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -1289,8 +1289,11 @@ extension Dictionary {`
`1289`	`1289`	`get {`
`1290`	`1290`	`return Values(_dictionary: self)`
`1291`	`1291`	`}`
`1292`		`- set {`
`1293`		`- self._variant = newValue._variant`
	`1292`	`+ _modify {`
	`1293`	`+ var values = Values(_dictionary: self)`
	`1294`	`+ _variant = .native(_NativeDictionary())`
	`1295`	`+ yield &values`
	`1296`	`+ self._variant = values._variant`
`1294`	`1297`	`}`
`1295`	`1298`	`}`
`1296`	`1299`