Merge pull request #68201 from atrick/verify-partialapply-callee

SIL verification: non-address partial apply callee

Author: atrick

SwiftCompilerSources/Sources/Optimizer/FunctionPasses/ComputeSideEffects.swift

@@ -153,10 +153,10 @@ private struct CollectedEffects {
       // handleApply above is sufficient. And, if they are not applied
       // in this function, then they are never applied.
       if !pa.isOnStack {
-        // the callee and its arguments are all captured...
-        for operand in pa.operands {
-          if operand.value.type.isAddress {
-            addEffects(.read, to: operand.value)
+        // callee is never an address.
+        for argument in pa.arguments {
+          if argument.type.isAddress {
+            addEffects(.read, to: argument)
           }
         }
       }

lib/SIL/Verifier/SILVerifier.cpp

@@ -1932,6 +1932,10 @@ class SILVerifier : public SILVerifierBase<SILVerifier> {
     require(resultInfo->getExtInfo().hasContext(),
             "result of closure cannot have a thin function type");
 
+    // We rely on all indirect captures to be in the argument list.
+    require(PAI->getCallee()->getType().isObject(),
+            "Closure callee must not be an address type.");
+
     checkApplyTypeDependentArguments(PAI);
 
     auto substTy = checkApplySubstitutions(PAI->getSubstitutionMap(),