[stdlib] Set, Dictionary: Make more Cocoa indexy things non-inlinable

Author: lorentey

stdlib/public/core/DictionaryBridging.swift

@@ -611,18 +611,21 @@ extension _CocoaDictionary {
 }
 
 extension _CocoaDictionary.Index {
-  @inlinable
+  @usableFromInline // FIXME(cocoa-index): Make inlinable
   @nonobjc
   internal var key: AnyObject {
-    _precondition(currentKeyIndex < allKeys.value,
-      "Attempting to access Dictionary elements using an invalid index")
-    return allKeys[currentKeyIndex]
+    @_effects(readonly)
+    get {
+      _precondition(currentKeyIndex < allKeys.value,
+        "Attempting to access Dictionary elements using an invalid index")
+      return allKeys[currentKeyIndex]
+    }
   }
 
-  @usableFromInline
+  @usableFromInline // FIXME(cocoa-index): Make inlinable
   @nonobjc
   internal var age: Int32 {
-    @_effects(releasenone)
+    @_effects(readonly)
     get {
       return _HashTable.age(for: base.object)
     }

stdlib/public/core/SetBridging.swift

@@ -391,7 +391,7 @@ extension _CocoaSet: _SetBuffer {
     return object.member(element) != nil
   }
 
-  @usableFromInline
+  @usableFromInline // FIXME(cocoa-index): Make inlinable
   @_effects(releasenone)
   internal func element(at i: Index) -> AnyObject {
     let element: AnyObject? = i.element
@@ -447,15 +447,18 @@ extension _CocoaSet {
 }
 
 extension _CocoaSet.Index {
-  @inlinable
+  @usableFromInline // FIXME(cocoa-index): Make inlinable
   @nonobjc
   internal var element: AnyObject {
-    _precondition(currentKeyIndex < allKeys.value,
-      "Attempting to access Set elements using an invalid index")
-    return allKeys[currentKeyIndex]
+    @_effects(readonly)
+    get {
+      _precondition(currentKeyIndex < allKeys.value,
+        "Attempting to access Set elements using an invalid index")
+      return allKeys[currentKeyIndex]
+    }
   }
 
-  @usableFromInline
+  @usableFromInline // FIXME(cocoa-index): Make inlinable
   @nonobjc
   internal var age: Int32 {
     @_effects(releasenone)