[benchmark] DictionaryRemove Setup Overhead

Author: palimondo

benchmark/single-source/DictionaryRemove.swift

@@ -16,39 +16,26 @@ import TestsUtils
 
 let t: [BenchmarkCategory] = [.validation, .api, .Dictionary]
 
+let size = 100
+let numberMap = Dictionary(uniqueKeysWithValues: zip(1...size, 1...size))
+let boxedNums = (1...size).lazy.map { Box($0) }
+let boxedNumMap = Dictionary(uniqueKeysWithValues: zip(boxedNums, boxedNums))
+
 public let DictionaryRemove = [
   BenchmarkInfo(name: "DictionaryRemove",
-    runFunction: run_DictionaryRemove, tags: t, legacyFactor: 10),
+    runFunction: { for _ in 1...$0*100 {
+      var dict = numberMap
+      for i in 1...size { dict.removeValue(forKey: i) }
+      CheckResults(dict.isEmpty)
+    }}, tags: t, legacyFactor: 10),
   BenchmarkInfo(name: "DictionaryRemoveOfObjects",
-    runFunction: run_DictionaryRemoveOfObjects, tags: t, legacyFactor: 100),
+    runFunction: { for _ in 1...$0*10 {
+      var dict = boxedNumMap
+      for i in 1...size { dict.removeValue(forKey: Box(i)) }
+      CheckResults(dict.isEmpty)
+    }}, tags: t, legacyFactor: 100),
 ]
 
-@inline(never)
-public func run_DictionaryRemove(_ N: Int) {
-    let size = 100
-    var dict = [Int: Int](minimumCapacity: size)
-
-    // Fill dictionary
-    for i in 1...size {
-        dict[i] = i
-    }
-    CheckResults(dict.count == size)
-
-    var tmpDict = dict
-    for _ in 1...100*N {
-        tmpDict = dict
-        // Empty dictionary
-        for i in 1...size {
-            tmpDict.removeValue(forKey: i)
-        }
-        if !tmpDict.isEmpty {
-            break
-        }
-    }
-
-    CheckResults(tmpDict.isEmpty)
-}
-
 class Box<T : Hashable> : Hashable {
   var value: T
 
@@ -64,29 +51,3 @@ class Box<T : Hashable> : Hashable {
     return lhs.value == rhs.value
   }
 }
-
-@inline(never)
-public func run_DictionaryRemoveOfObjects(_ N: Int) {
-    let size = 100
-    var dict = Dictionary<Box<Int>, Box<Int>>(minimumCapacity: size)
-
-    // Fill dictionary
-    for i in 1...size {
-        dict[Box(i)] = Box(i)
-    }
-    CheckResults(dict.count == size)
-
-    var tmpDict = dict
-    for _ in 1...10*N {
-        tmpDict = dict
-        // Empty dictionary
-        for i in 1...size {
-            tmpDict.removeValue(forKey: Box(i))
-        }
-        if !tmpDict.isEmpty {
-            break
-        }
-    }
-
-    CheckResults(tmpDict.isEmpty)
-}