[Concurrency] Further overload removals for Task.init

Author: ktoso

stdlib/public/Concurrency/Task.swift

@@ -580,70 +580,6 @@ func taskCreateFlags(
   return bits
 }
 
-// ==== Task Creation ----------------------------------------------------------
-
-@available(SwiftStdlib 5.1, *)
-extension Task where Failure == Never {
-#if SWIFT_STDLIB_TASK_TO_THREAD_MODEL_CONCURRENCY
-  @discardableResult
-  @_alwaysEmitIntoClient
-  @available(*, unavailable, message: "Unavailable in task-to-thread concurrency model")
-  public init(
-    priority: TaskPriority? = nil,
-    @_inheritActorContext @_implicitSelfCapture operation: sending @escaping @isolated(any) () async -> Success
-  ) {
-    fatalError("Unavailable in task-to-thread concurrency model.")
-  }
-#else
-  /// Runs the given nonthrowing operation asynchronously
-  /// as part of a new top-level task on behalf of the current actor.
-  ///
-  /// Use this function when creating asynchronous work
-  /// that operates on behalf of the synchronous function that calls it.
-  /// Like `Task.detached(priority:operation:)`,
-  /// this function creates a separate, top-level task.
-  /// Unlike `Task.detached(priority:operation:)`,
-  /// the task created by `Task.init(priority:operation:)`
-  /// inherits the priority and actor context of the caller,
-  /// so the operation is treated more like an asynchronous extension
-  /// to the synchronous operation.
-  ///
-  /// You need to keep a reference to the task
-  /// if you want to cancel it by calling the `Task.cancel()` method.
-  /// Discarding your reference to a detached task
-  /// doesn't implicitly cancel that task,
-  /// it only makes it impossible for you to explicitly cancel the task.
-  ///
-  /// - Parameters:
-  ///   - priority: The priority of the task.
-  ///     Pass `nil` to use the priority from `Task.currentPriority`.
-  ///   - operation: The operation to perform.
-  @discardableResult
-  @_alwaysEmitIntoClient
-  public init(
-    priority: TaskPriority? = nil,
-    @_inheritActorContext @_implicitSelfCapture operation: sending @escaping @isolated(any) () async -> Success
-  ) {
-    // Set up the job flags for a new task.
-    let flags = taskCreateFlags(
-      priority: priority, isChildTask: false, copyTaskLocals: true,
-      inheritContext: true, enqueueJob: true,
-      addPendingGroupTaskUnconditionally: false,
-      isDiscardingTask: false, isSynchronousStart: false)
-
-    // Create the asynchronous task.
-    let builtinSerialExecutor =
-      unsafe Builtin.extractFunctionIsolation(operation)?.unownedExecutor.executor
-
-    let (task, _) = Builtin.createTask(flags: flags,
-                                       initialSerialExecutor: builtinSerialExecutor,
-                                       operation: operation)
-
-    self._task = task
-  }
-#endif
-}
-
 @available(SwiftStdlib 5.1, *)
 extension Task where Failure == Never {
 #if SWIFT_STDLIB_TASK_TO_THREAD_MODEL_CONCURRENCY
@@ -662,10 +598,10 @@ extension Task where Failure == Never {
   @_alwaysEmitIntoClient
   @available(SwiftStdlib 5.1, *)
   public init( // Task.init where Failure == Never (Embedded)
-    name: String? = nil, // ignored
+    name: String? = nil,
     // TaskExecutor is unavailable in embedded
     priority: TaskPriority? = nil,
-    @_inheritActorContext @_implicitSelfCapture operation: sending @escaping () async -> Success
+    @_inheritActorContext @_implicitSelfCapture operation: sending @escaping @isolated(any) () async -> Success
   ) {
     // Set up the job flags for a new task.
     let flags = taskCreateFlags(
@@ -678,9 +614,31 @@ extension Task where Failure == Never {
       isDiscardingTask: false,
       isSynchronousStart: false)
 
-    let (task, _) = Builtin.createAsyncTask(flags, operation)
+    let builtinSerialExecutor =
+      unsafe Builtin.extractFunctionIsolation(operation)?.unownedExecutor.executor
 
-    self._task = task
+    var task: Builtin.NativeObject?
+    #if $BuiltinCreateAsyncTaskName
+    if let name {
+      task =
+        unsafe name.utf8CString.withUnsafeBufferPointer { nameBytes in
+          Builtin.createTask(
+            flags: flags,
+            initialSerialExecutor: builtinSerialExecutor,
+            taskName: nameBytes.baseAddress!._rawValue,
+            operation: operation).0
+        }
+    } // let name
+    #endif // $BuiltinCreateAsyncTaskName
+
+    if task == nil {
+      task = Builtin.createTask(
+        flags: flags,
+        initialSerialExecutor: builtinSerialExecutor,
+        operation: operation).0
+    }
+
+    self._task = task!
   }
 #else
   /// Runs the given nonthrowing operation asynchronously
@@ -817,25 +775,28 @@ extension Task where Failure == Error {
 
     var task: Builtin.NativeObject?
     #if $BuiltinCreateAsyncTaskName
-    if let name {
-      task =
-        unsafe name.utf8CString.withUnsafeBufferPointer { nameBytes in
-          Builtin.createTask(
-            flags: flags,
-            initialSerialExecutor: builtinSerialExecutor,
-            taskName: nameBytes.baseAddress!._rawValue,
-            operation: operation).0
-        }
-    }
+//    if let name {
+//      task =
+//        unsafe name.utf8CString.withUnsafeBufferPointer { nameBytes in
+//          Builtin.createTask(
+//            flags: flags,
+//            initialSerialExecutor: builtinSerialExecutor,
+//            taskName: nameBytes.baseAddress!._rawValue,
+//            operation: operation).0
+//        }
+//    }
     #endif
 
     if task == nil {
       // either no task name was set, or names are unsupported
-      task = Builtin.createTask(
-        flags: flags,
-        initialSerialExecutor: builtinSerialExecutor,
-        operation: operation).0
+//      task = Builtin.createTask(
+//        flags: flags,
+//        initialSerialExecutor: builtinSerialExecutor,
+//        operation: operation).0
     }
+    
+    
+    
 
     self._task = task!
   }